Skip to content

[main] Update dependencies from dotnet/runtime #47580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

[main] Update dependencies from dotnet/runtime #47580

merged 4 commits into from
Mar 17, 2025

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 14, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
e3bad43 
…0313.6

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.3.25162.19 -> To Version 10.0.0-preview.3.25163.6
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Mar 14, 2025
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@jeffschwMSFT
Copy link
Member

@dotnet/domestic-cat what does this scenario test failing indicate?

[FAIL] Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMVCTemplate(language: CSharp)
    System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25164.1
    Exit code: 139
    The template "global.json file" was created successfully.
    
       at Microsoft.DotNet.ScenarioTests.Common.ExecuteHelper.ValidateExitCode(ValueTuple`3 result, Int32 expectedExitCode) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.Common/ExecuteHelper.cs:line 112
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteCmdImpl(String args, String workingDirectory, Action`1 additionalProcessConfigCallback, Int32 expectedExitCode, Int32 millisecondTimeout) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 46
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteCmd(String args, String workingDirectory, Action`1 additionalProcessConfigCallback, Int32 expectedExitCode, Int32 millisecondTimeout) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 38
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteNew(String projectType, String projectName, String projectDirectory, String language, String customArgs) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 113
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTest.Execute(DotNetSdkHelper dotNetHelper, String testRoot, String[] frameworks, String PreMadeSolution, Int32 retryCounter) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTest.cs:line 42
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMVCTemplate(DotNetLanguage language) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs:line 181
       at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
       at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

@marcpopMSFT
Copy link
Member

@dotnet/domestic-cat what does this scenario test failing indicate?

[FAIL] Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMVCTemplate(language: CSharp)
    System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25164.1
    Exit code: 139

https://github.com/dotnet/scenario-tests/blob/main/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs#L176
@jeffschwMSFT this is a VMR test and should be routed to @dotnet/product-construction. However, from the output, there's a 139 exit code which usually means a crash on non-windows usually from something runtime related. Do the scenario tests collect dumps? I don't see any dumps in the pipeline artifacts.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
404ad30 
…0314.11

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.3.25162.19 -> To Version 10.0.0-preview.3.25164.11
@build-analysis build-analysis bot mentioned this pull request Mar 15, 2025
Open
dotnet-maestro bot added 2 commits March 16, 2025 05:01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
f5afda8 
…0315.3

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.3.25162.19 -> To Version 10.0.0-preview.3.25165.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
6667d2e 
…0316.3

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.3.25162.19 -> To Version 10.0.0-preview.3.25166.3
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 17, 2025 •
edited
Loading

Interesting. The build failed with commits 1 and 2 but then passed with commit 3. The runtime diff between the SHAs from commit 2 and 3 is: dotnet/runtime@17d6d52...4ca1691

Maybe @EgorBo's change fixed a potential regression?

@EgorBo
Copy link
Member

EgorBo commented Mar 17, 2025

Maybe @EgorBo's change fixed a potential regression?

I would be surprised it fixed anything 🙂

@dotnet-maestro dotnet-maestro bot merged commit bdd17aa into main Mar 17, 2025
43 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-b2123212-4882-459d-a8e0-44fb1d3e9536 branch March 17, 2025 10:14
@ViktorHofer
Copy link
Member

Yeah you are right. Apparently the test failure is non-deterministic. It just showed up in one of my PRs:

    System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25167.1
    Exit code: 139

#47657

@ViktorHofer
Copy link
Member

@jeffschwMSFT the crash showed up the first time in this PR with the first commit. The runtime diff for that commit is dotnet/runtime@5ff417f...c3d95b4

Can someone please double check these commits to see what could be causing the crash? Alternatively, a local repro might also be possible. It's of course also possible that a machine rollout / image / dependency update caused this.

@am11 am11 mentioned this pull request Mar 17, 2025
Merged
@ViktorHofer ViktorHofer mentioned this pull request Mar 17, 2025
Closed
@elinor-fung elinor-fung mentioned this pull request Mar 18, 2025
Merged
@ViktorHofer
Copy link
Member

Looks like this didn't fix the non-deterministic crash: dotnet/source-build#4952 (comment)

@jkotas jkotas mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffschwMSFT @marcpopMSFT @ViktorHofer @EgorBo