Skip to content

Fix bug when adding solution folder containing .. #46456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix bug when adding solution folder containing .. #46456

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c043f68
Fix bug when adding solution folder containing ..
edvilme Feb 1, 2025
96168b2
Refactor
edvilme Feb 3, 2025
1bb9e25
Apply pr suggestions
edvilme Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Cli/dotnet/commands/dotnet-sln/add/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ private async Task AddProjectsToSolutionAsync(string solutionFileFullPath, IEnum
string relativePath = Path.GetRelativePath(Path.GetDirectoryName(solutionFileFullPath), projectPath);
// Add fallback solution folder
string relativeSolutionFolder = Path.GetDirectoryName(relativePath);
// Don't add solution folder if it contains ..
if (relativeSolutionFolder.Contains(".."))
{
relativeSolutionFolder = string.Empty;
}

if (!_inRoot && solutionFolder is null && !string.IsNullOrEmpty(relativeSolutionFolder))
{
if (relativeSolutionFolder.Split(Path.DirectorySeparatorChar).LastOrDefault() == Path.GetFileNameWithoutExtension(relativePath))
Expand Down
Loading