Fix browser refresh after project restart #46172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-AspNetCore
Contributor
|
Thanks for your PR, @tmat. |
tmat
added
Servicing-consider
Area-Watch
and removed
Area-AspNetCore
Member
Author
|
@phil-allen-msft ptal |
phil-allen-msft
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #46112 to 2xx.
Context
dotnet-watch does not set environment variables correctly causing browser refresh to stop working after restarting a web project due to rude edit. The issue only occurs in Aspire orchestrated web projects, not in standalone web projects.
Customer impact
Web pages are not refreshed when further changes are made to the web project, after restarting due to rude edit, which greatly diminishes the value of Hot Reload.
Changes made
Apply the necessary environment variables to the restarted process.
Testing
Manual testing to confirm that the changes fix the issue.
Risks
Negligible. The fix is simple.