-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all test sdk references to the latest version. #45548
base: release/9.0.1xx
Are you sure you want to change the base?
Conversation
@dotnet/dotnet-testing I was talking with @Evangelink and he noticed that we had a bunch of old microsoft.net.test.sdk references so I tried to update them all.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Almost sounds like we should have a Version.props file just for the tests? Like, I see the fixed xunit versions in here too. I think all the tests should have a central location for their test packages, unless the test is testing a specific version of a package.
This is a quite common issue with VSTest but it can have many sources. I'll try to read the logs next week. |
72bf6a6
to
5c369f0
Compare
@Evangelink pinging after the holiday. any suggestions? |
From discussion with @nohwnd, it usually happens when the testhost process has crashed. We would need the diagnostic logs from when it happens (please refer to https://github.com/microsoft/vstest/blob/main/docs/troubleshooting.md) |
log says that you did not set the lower bound for the package, so the property used for the version is not propagating. This will reference a super old version of test.sdk, which is probably not compatible anymore and so it cannot respond to the handshake |
Linking dotnet/arcade#15402 |
5c369f0
to
45b6b2f
Compare
I don't think we have a good way of doing the version listed in the versions.props in a test itself (rather than a test asset built ahead of time). Open to suggestions on how to solve that.
For the rest, I don't know if the test infrastructure for those tests includes the version.props which could limit how many of these I can update.