Add a -sign switch and enable signing for some legs #44207
Conversation
Add a -sign switch, with dry run signing forced even when the official build ids are set. Enable for some legs in the VMR.
ghost
added
|
This will fail until the bootstrap arcade is updated, due to sn signing not being available on non-Windows. |
ellahathaway
left a comment
ellahathaway
left a comment
There was a problem hiding this comment.
This is a bit orthogonally related to this PR, but one thing I want to clarify is the type of signing that happens when we pass -sign & don't force dry-run signing (in the future).
Because MicroBuild install is not supported when SignType == test on non-windows builds, we cannot do test signing on mac and linux. We should ensure that just because -sign is passed doesn't mean test signing is enabled on non-windows builds. Maybe we continue to force dry-run signing in these scenarios?
We can add a check in Sign.proj for the SignType. If on non-windows, error in test scenarios. We don't really use test signing all that much, anyway. |
| targetArchitecture: x64 | ||
| useDevVersions: true # Use dev versions for CI validation of the experience. If we decide to ship assets from this leg, then we should remove this option. | ||
| runTests: false # Temporarily do not run tests. The nuget comparison fails for some non-obvious reason and needs further investigation. Mostly, I'm not sure why it ever passed. https://github.com/dotnet/sdk/issues/42920 | ||
| sign: true |
There was a problem hiding this comment.
What's the long-term strategy for this switch? I assume we won't control this per job in the future but per whole build?
There was a problem hiding this comment.
It will probably still be per job but default to true. We dont' need to sign everything, like PGO.
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Left one comment (bug around }}] in YML) that needs a fix but otherwise LGTM.
3 participants
Add a -sign switch, with dry run signing forced even when the official build ids are set. Enable for some legs in the VMR.