Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Update Windows SDK projection versions #43889

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

manodasanW
Copy link
Contributor

Updating Windows SDK projection

Fixes #43746
Fixes #43680

@marcpopMSFT
Copy link
Member

@manodasanW we discussed earlier in the week producing an RC2 build with this fix so we could test and confirm it fixed the issues. Do you need #43795 included in that build as well or just this one?

@manodasanW
Copy link
Contributor Author

@marcpopMSFT if you look at the latest comment in the linked issues, it looks like folks have been able to validate the fix in our package using the WindowsSdkPackageVersion property which this PR is updating to. But if we are still doing a build, it might be worthwhile to include both fixes.

@marcpopMSFT
Copy link
Member

@marcpopMSFT if you look at the latest comment in the linked issues, it looks like folks have been able to validate the fix in our package using the WindowsSdkPackageVersion property which this PR is updating to. But if we are still doing a build, it might be worthwhile to include both fixes.

@manodasanW when you say include both fixes, you mean include this commit which fixes #43746
and #43680 correct? Just double checking that it's just this one commit. Still looking for approval for the internal PR.

@manodasanW
Copy link
Contributor Author

@marcpopMSFT if you look at the latest comment in the linked issues, it looks like folks have been able to validate the fix in our package using the WindowsSdkPackageVersion property which this PR is updating to. But if we are still doing a build, it might be worthwhile to include both fixes.

@manodasanW when you say include both fixes, you mean include this commit which fixes #43746 and #43680 correct? Just double checking that it's just this one commit. Still looking for approval for the internal PR.

The package version updates in this PR fixes both of those referenced issues. My comment was regarding the other PR related to using WindowsSdkPackageVersion with old packages which we discussed offline and said given that wasn't a blocker, we won't take it in the internal build.

@marcpopMSFT
Copy link
Member

one failure was a known issue. Merging so we can get a build for testing.

@marcpopMSFT marcpopMSFT merged commit e928e71 into release/9.0.1xx Oct 15, 2024
27 of 31 checks passed
@marcpopMSFT marcpopMSFT deleted the manodasanW-patch-1 branch October 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK Servicing-approved untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants