Skip to content

Conversation

@Winniexu01
Copy link
Member

@Winniexu01 Winniexu01 commented Sep 20, 2024

Related to #43336

Fixes dotnet/source-build#4160

Store the prebuilt files for each repo as pipeline artifacts rather than the overall build's prebuilt report, which will make investigations of prebuilt go more quickly.

I introduced a new property DotNetBuildPrebuiltReportDir which point to artifacts\prebuilt-report\<reponame>\, all repo's prebuilt reports will respect this property and move to that folder.

@Winniexu01 Winniexu01 requested review from a team as code owners September 20, 2024 09:58
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Sep 20, 2024
@mthalman
Copy link
Member

@Winniexu01 - Can you explain why this is implemented differently from #43336? For example, this PR has changes to vmr-build.yml while the other did not. Additionally, this one defines PrebuiltReportsDir in the targets file while the other defines it in the props file. They should be as similar as possible between the two branches to ease the burden of backporting future updates.

@Winniexu01
Copy link
Member Author

@Winniexu01 - Can you explain why this is implemented differently from #43336? For example, this PR has changes to vmr-build.yml while the other did not. Additionally, this one defines PrebuiltReportsDir in the targets file while the other defines it in the props file. They should be as similar as possible between the two branches to ease the burden of backporting future updates.

Hi @mthalman, I did not do that before because the directory structure in main is changed that all files are stored under \artifacts but in 9.0, the logs for each repo are stored saved under \src\<repo>\artifacts. So I followed the old directory structure to store the prebuilt files to \src\<repo>\artifacts for 9.0. I will update the code .

@MichaelSimons MichaelSimons merged commit d2d9f34 into dotnet:release/9.0.1xx Sep 23, 2024
@Winniexu01 Winniexu01 deleted the 90prebuilt branch October 23, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants