Patch for Source-Build Stage 2 FSharp FS0064 Warnings #43436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
This was referenced Sep 13, 2024
Member
|
I think we should log a separate source-build issue to track cleaning up this change once the FSharp issue flows in. |
Member
Author
|
Testing patch with this pipeline run (internal Microsoft link) |
ellahathaway
changed the title
MichaelSimons
approved these changes
Sep 17, 2024
Member
|
/Backport to release/9.0.1xx-rc2 |
Member
|
/backport to release/9.0.1xx-rc2 |
Contributor
|
Started backporting to release/9.0.1xx-rc2: https://github.com/dotnet/sdk/actions/runs/10923005925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4603
Tested these changes with a local stage 2 build, and the fsharp build succeeded.
Should be reversed with dotnet/fsharp#17713