[release/9.0.1xx] Put binlog directly into the VMR's #43337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
|
What is the justification for the backport? It is late in the release cycle and these changes have low ROI because they are just re-organizing files and not adding any new functionality. I see #43336 depends on this though and it has a little high ROI in that it is adding functionality to capture additional prebuilt reports. I am on the fence. |
Member
|
@MichaelSimons To maintain consistency in the file structure between main and 9.0, so I create this backport. Then base on your description and ROI considerations, can we only backport the prebuilt report files to 9.0 without migrating the directory structure? Due to the low ROI of these changes, please help me close this backport as I do not have the permission to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42984 to release/9.0.1xx
/cc @Winniexu01