Fix .net 8.0 test templates #42585
Merged
Fix .net 8.0 test templates #42585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CodeFlow
untriaged
nohwnd
approved these changes
Aug 7, 2024
Evangelink
approved these changes
Aug 7, 2024
Thompson1985
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template inserted inside the .NET 9.0 for .NET 8.0 tfm is broken.
This is visible on vendors testing because on the machine there's only .NET 9 preview installed, otherwise the template can be picked up from the .NET 8.0 SDK.
This PR revert the template we ship for .NET 9 to the last good one shipped inside .NET 8.0.4xx
Version.Details.xml https://github.com/dotnet/installer/blob/release/8.0.4xx/eng/Version.Details.xml#L122-L125
Version.props https://github.com/dotnet/installer/blob/release/8.0.4xx/eng/Versions.props#L60
To test the fix I've build the package and overridden the
C:\Program Files\dotnet\templates\8.0.7\microsoft.dotnet.test.projecttemplates.8.0.1.1.0-rc.24202.1package installed with the "only" .NET 9 SDK on vendors repro machine.I did a manual test on vendors machine with 9.0 8.0 7.0 6.0 and looks good.
cc: @pavelhorak @Evangelink @nohwnd