[main] Update dependencies from dotnet/runtime #42262

dotnet-maestro · 2024-07-20T12:59:32Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
Build: 20240726.16
Date Produced: July 27, 2024 9:03:27 AM UTC
Commit: 827c83497bf4eb9816de2c223ea5c054e19954af
Branch: refs/heads/main

Updates:
- Microsoft.Bcl.AsyncInterfaces: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.DependencyModel: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.FileProviders.Abstractions: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.FileSystemGlobbing: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.Logging: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.Logging.Abstractions: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Extensions.Logging.Console: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NET.HostModel: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NETCore.App.Host.win-x64: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NETCore.App.Ref: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NETCore.Platforms: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.Win32.SystemEvents: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.CodeDom: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Composition.AttributedModel: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Composition.Convention: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Composition.Hosting: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Composition.Runtime: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Composition.TypedParts: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Configuration.ConfigurationManager: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Reflection.MetadataLoadContext: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Resources.Extensions: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Security.Cryptography.Pkcs: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Security.Cryptography.ProtectedData: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Security.Cryptography.Xml: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Security.Permissions: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.ServiceProcess.ServiceController: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Text.Encoding.CodePages: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Text.Json: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- System.Windows.Extensions: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24376.16
- Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.7.24365.1 to 9.0.0-rc.1.24373.3
- Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.7.24365.1 to 9.0.0-rc.1.24373.3

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.7.24365.1 to 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.7.24365.1 to 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)

…0719.11 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-preview.7.24369.11

dotnet-maestro · 2024-07-20T14:10:32Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

akoeplinger · 2024-07-21T07:22:57Z

@stephentoub there's a WPF build failure in C++/CLI due to dotnet/runtime#104942, is that expected?

D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileStream.h(32,39): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileLoader.h(25,35): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileEnumerator.h(30,43): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontCollectionLoader.h(28,45): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]

…0721.1 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-preview.7.24371.1

…0721.6 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-preview.7.24371.6

jeffschwMSFT · 2024-07-22T15:28:37Z

thanks @akoeplinger. @stephentoub thoughts?

cc @tgani-msft

stephentoub · 2024-07-22T21:23:01Z

We were not expecting this. @jaredpar, @333fred, it would appear C++/CLI treats Method(bool condition) and Method(bool condition, string? message = null) as being ambiguous?! This will kill our use of OverloadResolutionPriority.

stephentoub · 2024-07-22T21:27:32Z

Wait, I'm actually confused now. This failure:

FontCollectionLoader.h(28,45): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function

is pointing to this assert:

FontCollectionLoader() { Debug::Assert(false, "Assertion failed"); }

That's not what I'd have expected to become ambiguous. Such a call should have been unaffected, unless C++/CLI has strange behaviors in the face of [CallerArgumentExpression] / parameters with default values.

@tgani-msft, could you help shed some light on what's going on here?

333fred · 2024-07-22T21:33:10Z

dotnet/runtime@1f70f0c...db32911#diff-ec1b995e981684d2c5e77a6fcf040c738033a2c4d5b7d3278f1d6dd766407bc4
This is the relevant part of the diff showing what changed in the signature of Debug.Assert.

stephentoub · 2024-07-22T21:38:43Z

dotnet/[email protected]#diff-ec1b995e981684d2c5e77a6fcf040c738033a2c4d5b7d3278f1d6dd766407bc4 This is the relevant part of the diff showing what changed in the signature of Debug.Assert.

Right, we changed:

public static void Assert([DoesNotReturnIf(false)] bool condition, string? message)

to

public static void Assert([DoesNotReturnIf(false)] bool condition, [CallerArgumentExpression(nameof(condition))] string? message = null)

I don't know enough about C++/CLI overload resolution rules to understand why making the string? message optional broke anything.

stephentoub · 2024-07-22T22:00:13Z

All four of these:

D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileStream.h(32,39): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileLoader.h(25,35): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontFileEnumerator.h(30,43): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\DWriteWrapper\FontCollectionLoader.h(28,45): error C2668: 'System::Diagnostics::Debug::Assert': ambiguous call to overloaded function [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]

are of the form:

Debug::Assert(false, "Assertion failed");

While we figure out why things are going haywire and more broadly what to do about it, can we unblock things here by changing all of those to instead be:

Debug::Fail("Assertion failed");

which they arguably should have been anyway?

kasperk81 · 2024-07-22T22:46:36Z

dotnet/wpf#9441

jeffschwMSFT · 2024-07-22T23:06:38Z

@pchaurasia14 and @carlossanlop

…0722.7 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-preview.7.24372.7

stephentoub · 2024-07-23T14:07:50Z

I had a chat with @tgani-msft offline. We're not sure why Debug::Assert(false, "message") would result in ambiguities, and neither of us was able to construct an isolated repro that hit that. He suggested "the thing to do would be to get a preprocessed repro + all referenced assemblies from the WPF build" and that he'd need a full repro case to debug it.

However, that aside, he highlighted that:

Debug.Assert(bool condition);
Debug.Assert(bool condition, string? message = null);

will be ambiguous for a caller just doing Debug.Assert(condition), and that there's nothing we can do on the library side to avoid such a call being ambiguous with those two overloads, that this is just C++ overload resolution semantics.

Which at this point I believe means for .NET 9 we need to choose:

do we want to accept source breaks in C++/CLI code doing Debug.Assert(condition), the fix presumably being to add a message (though that then puts us into the unknown territory of why the wpf code doing exactly that was hitting amibiguities),
or do we want to revert the Debug.Assert changes in runtime, which then also throws into question the whole OverloadResolutionPriority C# feature.

jeffschwMSFT · 2024-07-23T15:25:00Z

do we want to accept source breaks in C++/CLI code doing Debug.Assert(condition), the fix presumably being to add a message (though that then puts us into the unknown territory of why the wpf code doing exactly that was hitting ambiguities),

Do we have a sense of the magnitude of this potential source breaking change? On a spectrum, if only 1 API (I am in favor of option 1). So the question is how many is too many?

I recommend that we gather a little data and then start heading towards option 1 - by filing a source breaking change notification for the affected APIs.

stephentoub · 2024-07-23T15:38:13Z

do we want to accept source breaks in C++/CLI code doing Debug.Assert(condition), the fix presumably being to add a message (though that then puts us into the unknown territory of why the wpf code doing exactly that was hitting ambiguities),

Do we have a sense of the magnitude of this potential source breaking change? On a spectrum, if only 1 API (I am in favor of option 1). So the question is how many is too many?

I recommend that we gather a little data and then start heading towards option 1 - by filing a source breaking change notification for the affected APIs.

This would only impact Debug.Assert. That's the only thing we changed (by making one of the arguments optional).

jeffschwMSFT · 2024-07-23T16:04:25Z

This would only impact Debug.Assert. That's the only thing we changed (by making one of the arguments optional).

Now that we know the impact, would we consider changing more in later releases?
My gut says we should file a source breaking chance for C++/CLI. Do you agree? (eg. as we add more we have to do this for them all?)

lewing · 2024-07-23T16:29:37Z

@javiercn looks like we need to disable fingerprinting for the tests at least temporarily

jeffschwMSFT · 2024-07-23T16:30:40Z

If necessary we can talk offline as we need to get a resolution soon. We snapped for Preview 7 yesterday and this is now blocking.

I am in favor of taking the WPF change and move forward with filing the breaking change. Others?

What is the next step there?

…0724.2 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-preview.7.24374.2 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.7.24365.1 -> To Version 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

jeffschwMSFT · 2024-07-24T15:41:57Z

@ericstj can you take a look at this?

The type 'IHybridCacheSerializer<T>' in 'D:\a\_work\1\vmr\src\aspnetcore\src\Caching\Hybrid\src\Runtime\IHybridCacheSerializer.cs' conflicts with the imported type 'IHybridCacheSerializer<T>' in 'Microsoft.Extensions.Caching.Abstractions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. Using the type defined in 'D:\a\_work\1\vmr\src\aspnetcore\src\Caching\Hybrid\src\Runtime\IHybridCacheSerializer.cs'.

The type 'IBufferDistributedCache' exists in both 'Microsoft.Extensions.Caching.Abstractions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.Extensions.Caching.Hybrid, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'

jeffschwMSFT · 2024-07-24T15:46:58Z

@lewing can you take a look at this wasm failure?

https://helix.dot.net/api/2019-06-17/jobs/36d41baf-5699-46ca-9efd-c72fe6e81897/workitems/Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests.dll.1/console

    Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests.WasmAoTPublishIntegrationTest.AoT_Publish_HostedAppWithScopedCss_VisualStudio [FAIL]
      Expected File "wwwroot/_framework/dotnet.native.wasm" cannot be found in directory "C:\h\w\B41609C6\t\dotnetSdkTests\bc25y5dz.bic\AoT_Publish_H---E44E9AE0\blazorhosted\bin\Release\net9.0\publish".
      Stack Trace:
           at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
           at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
           at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
           at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
           at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
           at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)

javiercn · 2024-07-24T15:52:48Z

@jeffschwMSFT I'll take a look.

~~I push a commit this morning but forgot to fix these, since they are hard to run locally. Will push another one.~~

Pushed an update.

nagilson · 2024-07-24T17:01:34Z

@javiercn thank you for that fix. We're seeing a similar error manifest now that the other one is resolved. May you PTAL?

System.IO.FileNotFoundException : Could not find file '/private/tmp/helix/working/AB980956/w/B0330A03/e/testExecutionDirectory/AoT_Publish_H---E44E9AE0/blazorhosted/bin/Release/net9.0/publish/wwwroot/custom-service-worker-assets.js'.

nagilson · 2024-07-24T17:05:30Z

@dotnet/product-construction

    /vmr/src/aspnetcore/src/Caching/StackExchangeRedis/src/RedisCache.cs(740,27): error CS0538: 'IBufferDistributedCache' in explicit interface declaration is not an interface [/vmr/src/aspnetcore/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj::TargetFramework=net8.0]

It appears there is an issue with the interface in the VMR. May you PTAL?

ericstj · 2024-07-24T18:47:04Z

@ericstj can you take a look at this?

The type 'IHybridCacheSerializer<T>' in 'D:\a\_work\1\vmr\src\aspnetcore\src\Caching\Hybrid\src\Runtime\IHybridCacheSerializer.cs' conflicts with the imported type 'IHybridCacheSerializer<T>' in 'Microsoft.Extensions.Caching.Abstractions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. Using the type defined in 'D:\a\_work\1\vmr\src\aspnetcore\src\Caching\Hybrid\src\Runtime\IHybridCacheSerializer.cs'.

The type 'IBufferDistributedCache' exists in both 'Microsoft.Extensions.Caching.Abstractions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'Microsoft.Extensions.Caching.Hybrid, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'

That's due to dotnet/runtime#103103. @mgravell - is ASP.NET working on an update that deletes these? I'm a bit surprised that the runtime update doesn't first flow through aspnet, which would catch this. cc @mmitche

@dotnet/product-construction

    /vmr/src/aspnetcore/src/Caching/StackExchangeRedis/src/RedisCache.cs(740,27): error CS0538: 'IBufferDistributedCache' in explicit interface declaration is not an interface [/vmr/src/aspnetcore/src/Caching/StackExchangeRedis/src/Microsoft.Extensions.Caching.StackExchangeRedis.csproj::TargetFramework=net8.0]

It appears there is an issue with the interface in the VMR. May you PTAL?

@nagilson - I think this one is also related to the above feature. Seems that types were added to runtime that previously ASP.NET defined. ASP.NET needs to react to the additions.

Update, I see @mgravell already working on this here: dotnet/aspnetcore#56945, and dotnet/aspnetcore#56962

ViktorHofer · 2024-07-24T18:57:03Z

I'm a bit surprised that the runtime update doesn't first flow through aspnet, which would catch this.

Runtime flows into sdk and aspnetcore in parallel. See dotnet/aspnetcore#56848, same failures there.

…0724.13 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24374.13 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.7.24365.1 -> To Version 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0725.13 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24375.13 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.7.24365.1 -> To Version 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

jeffschwMSFT · 2024-07-26T16:23:42Z

@ViktorHofer what is the next step to unblock this one? (I see that the aspnet dependency flow has merged)

ViktorHofer · 2024-07-26T16:47:06Z

I think that this dependency flow and #42398 need to be merged together into one PR.

mmitche · 2024-07-26T22:53:37Z

That's due to dotnet/runtime#103103. @mgravell - is ASP.NET working on an update that deletes these? I'm a bit surprised that the runtime update doesn't first flow through aspnet, which would catch this. cc @mmitche

Furthermore, it flows into windowsdesktop in parallel too. We don't want to preference one shared framework working over the other.

akoeplinger · 2024-07-27T06:57:21Z

Two workloads-related test failures from the VerifyWorkloadCmd scenario test:

System.InvalidOperationException : Failed to execute /vmr/artifacts/obj/extracted-dotnet-sdk/dotnet workload install wasm-tools --skip-manifest-update
Exit code: 1
Workload installation failed: Workload ID wasm-tools is not recognized.

and

System.InvalidOperationException : Failed to execute /vmr/artifacts/obj/extracted-dotnet-sdk/dotnet workload install wasm-tools --skip-manifest-update
Exit code: 1
Workload installation failed: Could not find workload 'microsoft-net-runtime-android-net8' extended by workload 'android' in manifest 'microsoft.net.sdk.android' [/vmr/artifacts/obj/extracted-dotnet-sdk/sdk-manifests/9.0.100-preview.6/microsoft.net.sdk.android/34.99.0-preview.6.340/WorkloadManifest.json]

…0726.16 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24376.16 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.7.24365.1 -> To Version 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

akoeplinger · 2024-07-27T21:42:12Z

Yay 🎉

dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jul 20, 2024

build-analysis bot mentioned this pull request Jul 21, 2024

Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305

Open

3 tasks

nagilson approved these changes Jul 22, 2024

View reviewed changes

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

51ba9d8

kasperk81 mentioned this pull request Jul 22, 2024

Debug::Assert(false to Debug::Fail dotnet/wpf#9441

Merged

anjali-wpf added 2 commits July 23, 2024 12:40

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

fd5a5c7

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

a4a00a9

build-analysis bot mentioned this pull request Jul 23, 2024

Microsoft.NET.Build.Containers.IntegrationTests are pulling from Docker Hub #42026

Open

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

b2f3022

javiercn requested review from a team as code owners July 24, 2024 12:58

Disable fingerprinting for AoT tests

2653a1c

nagilson added the Area-VMR label Jul 24, 2024

build-analysis bot mentioned this pull request Jul 24, 2024

msbuild crashes with "MSB0001: Internal MSBuild Error: must be valid" dotnet/dnceng#3304

Open

3 tasks

javiercn and others added 2 commits July 24, 2024 21:09

Additional fix

93e1021

This was referenced Jul 25, 2024

The "RestoreTask" task returned false but did not log an error dotnet/dnceng#3100

Open

ToolInstallCommandTests.WhenRunWithRoot is flaky #42346

Open

nagilson and others added 2 commits July 25, 2024 10:59

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

e9f3656

akoeplinger added 2 commits July 26, 2024 21:58

Update aspnetcore dependencies

3b1af2d

Merge branch 'main' into darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b

307391b

akoeplinger mentioned this pull request Jul 26, 2024

[main] Update dependencies from dotnet/aspnetcore #42398

Closed

dotnet-maestro bot merged commit 1b87a11 into main Jul 27, 2024
41 checks passed

dotnet-maestro bot deleted the darc-main-f291a482-3bda-49b6-8005-dd1ec1224b1b branch July 27, 2024 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #42262

[main] Update dependencies from dotnet/runtime #42262

dotnet-maestro bot commented Jul 20, 2024 •

edited

Loading

dotnet-maestro bot commented Jul 20, 2024

akoeplinger commented Jul 21, 2024

jeffschwMSFT commented Jul 22, 2024

stephentoub commented Jul 22, 2024

stephentoub commented Jul 22, 2024 •

edited

Loading

333fred commented Jul 22, 2024

stephentoub commented Jul 22, 2024

stephentoub commented Jul 22, 2024

kasperk81 commented Jul 22, 2024

jeffschwMSFT commented Jul 22, 2024

stephentoub commented Jul 23, 2024 •

edited

Loading

jeffschwMSFT commented Jul 23, 2024

stephentoub commented Jul 23, 2024

jeffschwMSFT commented Jul 23, 2024

lewing commented Jul 23, 2024

jeffschwMSFT commented Jul 23, 2024

jeffschwMSFT commented Jul 24, 2024 •

edited

Loading

jeffschwMSFT commented Jul 24, 2024

javiercn commented Jul 24, 2024 •

edited

Loading

nagilson commented Jul 24, 2024

nagilson commented Jul 24, 2024

ericstj commented Jul 24, 2024 •

edited

Loading

ViktorHofer commented Jul 24, 2024

jeffschwMSFT commented Jul 26, 2024

ViktorHofer commented Jul 26, 2024

mmitche commented Jul 26, 2024

akoeplinger commented Jul 27, 2024 •

edited

Loading

akoeplinger commented Jul 27, 2024

[main] Update dependencies from dotnet/runtime #42262

[main] Update dependencies from dotnet/runtime #42262

Conversation

dotnet-maestro bot commented Jul 20, 2024 • edited Loading

From https://github.com/dotnet/runtime

Coherency Updates

dotnet-maestro bot commented Jul 20, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

akoeplinger commented Jul 21, 2024

jeffschwMSFT commented Jul 22, 2024

stephentoub commented Jul 22, 2024

stephentoub commented Jul 22, 2024 • edited Loading

333fred commented Jul 22, 2024

stephentoub commented Jul 22, 2024

stephentoub commented Jul 22, 2024

kasperk81 commented Jul 22, 2024

jeffschwMSFT commented Jul 22, 2024

stephentoub commented Jul 23, 2024 • edited Loading

jeffschwMSFT commented Jul 23, 2024

stephentoub commented Jul 23, 2024

jeffschwMSFT commented Jul 23, 2024

lewing commented Jul 23, 2024

jeffschwMSFT commented Jul 23, 2024

jeffschwMSFT commented Jul 24, 2024 • edited Loading

jeffschwMSFT commented Jul 24, 2024

javiercn commented Jul 24, 2024 • edited Loading

nagilson commented Jul 24, 2024

nagilson commented Jul 24, 2024

ericstj commented Jul 24, 2024 • edited Loading

ViktorHofer commented Jul 24, 2024

jeffschwMSFT commented Jul 26, 2024

ViktorHofer commented Jul 26, 2024

mmitche commented Jul 26, 2024

akoeplinger commented Jul 27, 2024 • edited Loading

akoeplinger commented Jul 27, 2024

dotnet-maestro bot commented Jul 20, 2024 •

edited

Loading

stephentoub commented Jul 22, 2024 •

edited

Loading

stephentoub commented Jul 23, 2024 •

edited

Loading

jeffschwMSFT commented Jul 24, 2024 •

edited

Loading

javiercn commented Jul 24, 2024 •

edited

Loading

ericstj commented Jul 24, 2024 •

edited

Loading

akoeplinger commented Jul 27, 2024 •

edited

Loading