Skip to content

Remove unnecessary RemoveMSDiaTypeLib target from GenerateLayout.targets #39304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Mar 8, 2024
Merged

Remove unnecessary RemoveMSDiaTypeLib target from GenerateLayout.targets #39304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2025b4
Remove unnecessary RemoveMSDiaTypeLib target from GenerateLayout.targets
akoeplinger Mar 7, 2024
d8ba031
Actually remove the target
akoeplinger Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Layout/redist/targets/GenerateLayout.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,14 +395,6 @@
AssetPath="%(NuPkgContentForMSBuildExtensionsRelativePaths.Identity)" />
</Target>

<!-- The msdia140typelib_clr0200.dll file is not MIT licensed (and it only used on Windows). Remove it, so
we can MIT license the published dotnet -->
<Target Name="RemoveMSDiaTypeLib"
AfterTargets="Build"
Condition="'$(OSName)' != 'win'">
<Delete Files="$(OutputPath)/TestHost/msdia140typelib_clr0200.dll" />
</Target>

<Target Name="PublishSdks"
AfterTargets="Build">
<ItemGroup>
Expand Down Expand Up @@ -488,7 +480,6 @@
MakeFscRunnableAndMoveToPublishDir;
RemoveFscFilesAfterPublish;
PublishTargetExtensions;
RemoveMSDiaTypeLib;
PublishSdks;
ChmodPublishDir;
DeleteSymbolsFromPublishDir;
Expand Down