Skip to content

[main] Update dependencies from dotnet/msbuild #37242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 8, 2023
Merged

[main] Update dependencies from dotnet/msbuild #37242

merged 7 commits into from
Dec 8, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 30, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20231205.2
  • Date Produced: December 5, 2023 6:29:14 AM UTC
  • Commit: 2f3d37672a69142a13a62856b09034a915bedc70
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
afc9ab7 
…1130.4

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23580-04
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Nov 30, 2023
@v-wuzhai
Copy link
Contributor

v-wuzhai commented Dec 1, 2023

@dotnet/msbuild-admins Could you take a look at the failures here?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
0979f6c 
…1201.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23601-02
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Dec 1, 2023

@dotnet/kitten to take a loo and @tmat @arkalyanms as the test failure is in the watch tests

at Microsoft.DotNet.Watcher.Tools.AwaitableProcess.GetOutputLineAsync(Predicate`1 success, Predicate`1 failure) in /_/src/Tests/dotnet-watch.Tests/Utilities/AwaitableProcess.cs:line 81

@Forgind
Copy link
Contributor

Forgind commented Dec 2, 2023

The PR that introduced this failure was dotnet/msbuild#9387

/cc: @JanKrivanek (author)

'dotnet watch ⌚ System.AggregateException: One or more errors occurred. (The expression "[MSBuild]::StableStringHash(AppWithDeps.csproj)" cannot be evaluated. Could not load type 'Microsoft.NET.StringTools.FowlerNollVo1aHash' from assembly 'Microsoft.NET.StringTools, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.  /datadisks/disk1/work/AD580957/p/d/sdk/9.0.100-ci/Microsoft.Common.CurrentVersion.targets)'

@Forgind
Copy link
Contributor

Forgind commented Dec 2, 2023

From that error message, it sounds like it's finding the assembly but not the new type. It seems that M.B has a ProjectReference to StringTools, so I don't think this is just pulling from an old feed, and I would've expected them to be updated together. Is StringTools missed in a build step, perhaps, and that means we're getting a stale version here?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
b66d9a1 
…1201.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23601-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
0ac3089 
…1201.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23601-02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
79e4e67 
…1204.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23604-01
@rainersigwald rainersigwald mentioned this pull request Dec 4, 2023
Merged
@rainersigwald
Copy link
Member

rainersigwald commented Dec 4, 2023 •
edited
Loading

dotnet-watch ships its own copy of some MSBuild assemblies including DotnetTools\dotnet-watch\9.0.100-dev\tools\net9.0\any\Microsoft.NET.StringTools.dll. #37310 should fix, feel free to cherry-pick it here if you want.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
ceead35 
…1205.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.9.0-preview-23578-04 -> To Version 17.9.0-preview-23605-02
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Dec 7, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 7, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@marek-safar marek-safar merged commit 8e447c8 into main Dec 8, 2023
@marek-safar marek-safar deleted the darc-main-8ef091db-1c97-4e5d-a8de-85be5ae2c104 branch December 8, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v-wuzhai @marcpopMSFT @Forgind @rainersigwald @marek-safar