Skip to content

Added test for .user file in outer build #37192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2024
+41 −0
Merged

Added test for .user file in outer build #37192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324bdfd
Added test for .user file in outer build
maridematte Nov 28, 2023
883818b
Added Required MSBuild version to the test
maridematte Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACrossTargetedLibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,46 @@ public void OutputPathDoesNotHaveDuplicatedBackslashesInOuterBuild()
string outputPathValue = File.ReadAllText(Path.Combine(testAsset.TestRoot, testProject.Name, "OutputPathValue.txt"));
outputPathValue.Trim().Should().NotContain("\\\\");
}

[RequiresMSBuildVersionFact("17.9.0.61803")]
public void OuterBuildImportsUserFile()
{
var testProject = new TestProject()
{
TargetFrameworks = $"{ToolsetInfo.CurrentTargetFramework};net7.0"
};

testProject.ProjectChanges.Add(xml =>
{
var target = """
<Target Name="WriteValue" AfterTargets="Build">
<WriteLinesToFile File="$(MSBuildProjectDirectory)\OutputPathValue.txt"
Lines="User value is: $(UserValue)"
Overwrite="true" />
</Target>
""";

xml.Root.Add(XElement.Parse(target));
});

string temp = $"{testProject.Name}.csproj.user";
testProject.SourceFiles[temp] = """
<Project>
<PropertyGroup>
<UserValue>A User defined value</UserValue>
</PropertyGroup>
</Project>
""";

var testAsset = _testAssetsManager.CreateTestProject(testProject);

new BuildCommand(testAsset)
.Execute()
.Should()
.Pass();

string outputPathValue = File.ReadAllText(Path.Combine(testAsset.TestRoot, testProject.Name, "OutputPathValue.txt"));
Copy link
Member

@rainersigwald rainersigwald Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file could have been created by inner builds, though, right? Though I guess since this is after Build, the outer build would have overwritten it with an empty one . . .

Copy link
Member Author

@maridematte maridematte Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the file will be created by the inner builds too, but the outer one will be the last and will override whatever is there.

outputPathValue.Should().Contain("User value is: A User defined value");
}
}
}