Opting into dependentupon convention #3533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Should this be conditional on target framework or used for anything using the sdk? |
Contributor
|
I think this should be conditional on target framework >= netcoreapp3.0 or >= netstandard2.1. Otherwise, this would be a potential breaking change. |
Contributor
|
cc @davkean |
Note: This test fails without its MSBuild counterpart. I verified that this test ran successfully on a local machine with a version of MSBuild that had the needed change. Until that change is merged in, this test will skip & refer to the original issue.
wjk
suggested changes
Aug 16, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
nguerrera
suggested changes
Aug 17, 2019
Contributor
nguerrera
left a comment
nguerrera
left a comment
There was a problem hiding this comment.
Needs to be .netstandard 2.1 not .netframework.
nguerrera
approved these changes
Aug 18, 2019
rainersigwald
approved these changes
Aug 19, 2019
Co-Authored-By: Rainer Sigwald <raines@microsoft.com>
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….4 (dotnet#3533) - Microsoft.NET.Sdk - 3.1.100-preview3.19561.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In SDK projects and new project system, we have eliminated the need for DependentUpon to make the appropriate file nesting in the IDE tree. However, there is a place where the build actually uses DependentUpon to:
But people and features in VS rely on this and it has been a consistent source of feedback in moving to .NET Core 3.0. This opts into new behavior to use a convention instead of requiring explicit metadata.
Original issue: dotnet/msbuild#4488
This change is dependent upon: dotnet/msbuild#4597
Customer Impact
In a fairly common situation for projects that use resources, avoids the need to specify
DependentUponmetadata for each resource.Regression?
No
Risk
Low risk.
Test changes in this PR
Added
DependentUponTest. Currently it gets skipped, but this test was verified working on a local machine using a version of MSBuild that had the corresponding fix.