Move to granular opt-in for interceptors preview #35024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
captainsafia
force-pushed
the
safia/rdg-flag-fix
branch
from
b4dd62f to
f966833
Compare
captainsafia
force-pushed
the
safia/rdg-flag-fix
branch
from
f966833 to
7c19e60
Compare
layomia
reviewed
Sep 1, 2023
|
|
||
| VerifyConfigBindingGeneratorIsUsed(asset, isEnabled); | ||
| VerifyInterceptorsFeatureEnabled(asset, isEnabled); | ||
| VerifyInterceptorsFeatureEnabled(asset, isEnabled, "Microsoft.Extensions.Configuration.Binder.SourceGeneration"); |
There was a problem hiding this comment.
nit: these Verify* method names read like they (always) assert that the generator(s) are used/enabled. Consider using names that indicate that the expected behavior depends on whether the generator is enabled (e.g VerifyInterceptorsFeatureSettingIsCorrect).
src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets
Outdated
Show resolved
Hide resolved
layomia
approved these changes
Sep 2, 2023
eerhardt
approved these changes
Sep 5, 2023
|
Merging. This is not a breaking change and doesn't introduce new behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.