Add additional dependencies for PVP flow #33179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
mthalman
reviewed
Jun 12, 2023
eng/Version.Details.xml
Outdated
| <Sha>27e584661980ee6d82c419a2a471ae505b7d122e</Sha> | ||
| <SourceBuild RepoName="symreader" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <!-- Dependencies required for flowing correct package versions in source-build, using PVP flow. --> |
Member
There was a problem hiding this comment.
Consider applying this comment to every dependency you've added so that there isn't confusion about which packages this applies to.
For example, someone may insert an additional dependency at the end of the list here not knowing that this comment would be interpreted to be relevant to that new package even though that wasn't the intention.
Member
Author
There was a problem hiding this comment.
Will do - I considered listing dependencies in the comment, but your suggestion seems cleaner.
26 tasks
mthalman
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
PVP flow is a method of flowing dependencies in source build that only overrides versions of packages that the repo has a declared dependency on in
Version.Details.xml. This means that the package flow is closer to the Microsoft's way of building .NET.To enable this for
sdk, we've addednuget.clientandvstestdependencies with #33039. However, 3 dependencies are needed to prevent introduction of reference assemblies and runtime issues. This PR adds these additional dependencies. Patch for this change is being added to existing PR ininstaller: dotnet/installer#16633To fully enable PVP flow, the repo project in the VMR will need to set
<PackageVersionPropsFlowType>DependenciesOnly</PackageVersionPropsFlowType>once these changes flow in.