Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
cc40871
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 20, 2023
ebe4874
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 20, 2023
1c1d3bc
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 20, 2023
47bba42
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 20, 2023
209fea9
[release/7.0.4xx] Update dependencies from dotnet/razor (#31902)
dotnet-maestro[bot] Apr 20, 2023
63acc09
[release/7.0.4xx] Update dependencies from dotnet/roslyn (#31915)
joeloff Apr 20, 2023
922f96a
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
f53e9a9
[release/7.0.4xx] Update dependencies from dotnet/roslyn (#31923)
v-wuzhai Apr 21, 2023
9843b60
Update dependencies from https://github.com/dotnet/msbuild build 2023…
dotnet-maestro[bot] Apr 21, 2023
b630ea9
Update dependencies from https://github.com/dotnet/msbuild build 2023…
dotnet-maestro[bot] Apr 21, 2023
ae6a610
Update dependencies from https://github.com/microsoft/vstest build 20…
dotnet-maestro[bot] Apr 21, 2023
3aebe9f
[release/7.0.4xx] Update dependencies from microsoft/vstest (#31928)
v-wuzhai Apr 21, 2023
6d2264e
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
56b3ce0
Update dependencies from https://github.com/dotnet/fsharp build 20230…
dotnet-maestro[bot] Apr 21, 2023
b7f0734
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
e0b4e19
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Apr 21, 2023
bc54986
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
cf8c22e
[release/7.0.4xx] Update dependencies from dotnet/fsharp (#31935)
joeloff Apr 21, 2023
4034c0b
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Apr 21, 2023
2f3896d
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
a84060a
Revert "Respond to ProduceReferenceAssembly default changing to true …
rainersigwald Apr 21, 2023
281a6a4
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
162443b
[release/7.0.4xx] Update dependencies from dotnet/msbuild (#31927)
marcpopMSFT Apr 21, 2023
fc30d7b
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 21, 2023
65c6fb1
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 22, 2023
09689e1
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 22, 2023
829650b
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 22, 2023
ea05a0d
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 22, 2023
56d553b
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Apr 22, 2023
0cce763
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Apr 22, 2023
f5edde3
[release/7.0.4xx] Update dependencies from nuget/nuget.client (#31948)
v-wuzhai Apr 23, 2023
9338256
[release/7.0.4xx] Update dependencies from dotnet/roslyn (#31934)
v-wuzhai Apr 23, 2023
6ebcfec
[release/7.0.4xx] Update dependencies from dotnet/arcade (#31951)
v-wuzhai Apr 23, 2023
d04632b
Merge branch 'release/7.0.4xx'
Apr 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>ab2b80d06dd4d997df5ffa72a3c4a99cb36ccbff</Sha>
</Dependency>
<Dependency Name="Microsoft.Build" Version="17.7.0-preview-23217-02">
<Dependency Name="Microsoft.Build" Version="17.7.0-preview-23221-02">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>2cbc8b6aef648cf21c6a68a0dab7fe09a614e475</Sha>
<Sha>ac3f5ad89f3f04d080986607d504a838ed622fb9</Sha>
<SourceBuild RepoName="msbuild" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Build.Localization" Version="17.7.0-preview-23217-02">
<Dependency Name="Microsoft.Build.Localization" Version="17.7.0-preview-23221-02">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>2cbc8b6aef648cf21c6a68a0dab7fe09a614e475</Sha>
<Sha>ac3f5ad89f3f04d080986607d504a838ed622fb9</Sha>
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.7.0-preview-23217-02">
<Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.7.0-preview-23221-02">
<Uri>https://github.com/dotnet/msbuild</Uri>
<Sha>2cbc8b6aef648cf21c6a68a0dab7fe09a614e475</Sha>
<Sha>ac3f5ad89f3f04d080986607d504a838ed622fb9</Sha>
</Dependency>
<Dependency Name="Microsoft.FSharp.Compiler" Version="12.5.0-beta.23221.1">
<Uri>https://github.com/dotnet/fsharp</Uri>
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/Microsoft/msbuild -->
<MicrosoftBuildPackageVersion>17.7.0-preview-23217-02</MicrosoftBuildPackageVersion>
<MicrosoftBuildPackageVersion>17.7.0-preview-23221-02</MicrosoftBuildPackageVersion>
<MicrosoftBuildCurrentPackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildCurrentPackageVersion>
<!-- Some tasks and the resolver will need to run in an MSBuild that is older than the very latest,
so target one that matches the version in minimumMSBuildVersion.
Expand All @@ -109,7 +109,7 @@
<MicrosoftBuildPackageVersion Condition="exists('$(RepoRoot)\src\Layout\redist\minimumMSBuildVersion') and '$(DotNetBuildFromSource)' != 'true'">$([System.IO.File]::ReadAllText('$(RepoRoot)\src\Layout\redist\minimumMSBuildVersion').Trim())</MicrosoftBuildPackageVersion>
<MicrosoftBuildFrameworkPackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildFrameworkPackageVersion>
<MicrosoftBuildRuntimePackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildRuntimePackageVersion>
<MicrosoftBuildLocalizationPackageVersion>17.7.0-preview-23217-02</MicrosoftBuildLocalizationPackageVersion>
<MicrosoftBuildLocalizationPackageVersion>17.7.0-preview-23221-02</MicrosoftBuildLocalizationPackageVersion>
<MicrosoftBuildUtilitiesCorePackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildUtilitiesCorePackageVersion>
<MicrosoftBuildTasksCorePackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildTasksCorePackageVersion>
<MicrosoftBuildVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,9 @@ Copyright (c) .NET Foundation. All rights reserved.
<!-- Hook for processing after target framework parsing (for example to customize output paths) -->
<Import Project="$(AfterTargetFrameworkInferenceTargets)" Condition="$(AfterTargetFrameworkInferenceTargets) != ''" />

<PropertyGroup>
<ProduceReferenceAssembly Condition="'$(ProduceReferenceAssembly)' == '' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 5.0)) and ('$(ProduceOnlyReferenceAssembly)' != 'true') and '$(MSBuildProjectExtension)' != '.fsproj'" >true</ProduceReferenceAssembly>
<ProduceReferenceAssembly Condition="'$(ProduceReferenceAssembly)' == '' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 7.0)) and ('$(ProduceOnlyReferenceAssembly)' != 'true') and '$(MSBuildProjectExtension)' == '.fsproj'" >true</ProduceReferenceAssembly>
</PropertyGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ public void It_errors_when_publishing_single_file_without_apphost()
.Pass();
}

[RequiresMSBuildVersionTheory("17.7.0")]
[Theory]
[InlineData(true)]
[InlineData(false)]
public void It_builds_the_project_successfully_with_only_reference_assembly_set(bool produceOnlyReferenceAssembly)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using Xunit.Abstractions;
using Microsoft.NET.TestFramework.Assertions;
using Microsoft.NET.TestFramework.ProjectConstruction;
using System.Collections.Generic;

namespace Microsoft.NET.Build.Tests
{
Expand All @@ -17,35 +18,26 @@ public class GivenThatWeWantToProduceReferenceAssembly : SdkTest
public GivenThatWeWantToProduceReferenceAssembly(ITestOutputHelper log) : base(log)
{}

[RequiresMSBuildVersionTheory("17.7.0")]
[InlineData("netcoreapp3.1", ".csproj")]
[InlineData("net5.0", ".csproj")]
[InlineData("net5.0", ".fsproj")]
[InlineData("net6.0", ".csproj")]
[InlineData("net6.0", ".fsproj")]
[InlineData("net7.0", ".csproj")]
[InlineData("net7.0", ".fsproj")]
#pragma warning disable xUnit1025 // InlineData duplicates
[InlineData(ToolsetInfo.CurrentTargetFramework, ".csproj")]
[InlineData(ToolsetInfo.CurrentTargetFramework, ".fsproj")]
#pragma warning restore xUnit1025 // InlineData duplicates
public void It_produces_ref_assembly_for_appropriate_frameworks(string targetFramework, string extension)
[RequiresMSBuildVersionTheory("16.8.0")]
[InlineData("netcoreapp3.1", false)]
[InlineData(ToolsetInfo.CurrentTargetFramework, true)]
public void It_produces_ref_assembly_for_appropriate_frameworks(string targetFramework, bool expectedExists)
{
TestProject testProject = new()
TestProject testProject = new TestProject()
{
Name = "ProduceRefAssembly",
IsExe = true,
TargetFrameworks = targetFramework,
};

var testAsset = _testAssetsManager.CreateTestProject(testProject, identifier: targetFramework + extension, targetExtension: extension);
var testAsset = _testAssetsManager.CreateTestProject(testProject, identifier: targetFramework);

var buildCommand = new BuildCommand(testAsset);
buildCommand.Execute()
.Should()
.Pass();
var filePath = Path.Combine(testAsset.Path, testProject.Name, "obj", "Debug", targetFramework, "ref", $"{testProject.Name}.dll");
File.Exists(filePath).Should().BeTrue();
File.Exists(filePath).Should().Be(expectedExists);
}
}
}