Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 15, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
  • Build: 20230419.1
  • Date Produced: April 19, 2023 2:08:29 PM UTC
  • Commit: f182ffbd63af02071c127b27d2478fd51e69e983
  • Branch: refs/heads/main

…15.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23215.1
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Apr 15, 2023
@v-wuzhai
Copy link
Contributor

@dotnet/razor-compiler Could you take a look at the failures here?

@jjonescz
Copy link
Member

That's weird. The error is due to missing DLL Microsoft.AspNetCore.Razor.Utilities.Shared. And indeed, the transport package Microsoft.CodeAnalysis.Razor.Tooling.Internal version 7.0.0-preview.23213.4 contains the DLL, but the next version 7.0.0-preview.23215.1 doesn't. However, I don't see any relevant change in Razor between these versions: dotnet/razor@8f16bb8...2ae218d

@joeloff
Copy link
Member

joeloff commented Apr 18, 2023

However, I don't see any relevant change in Razor between these versions:

Was this from the last ASP.NET build where the package disappeared? The binlog might offer some clues

@jjonescz
Copy link
Member

jjonescz commented Apr 19, 2023

I realized this is from release/dev17.6 of Razor which probably needs backport of my fix: dotnet/razor#8611.

Or should the flow be fixed instead? E.g. to flow main version of Razor here instead of 17.6? Not sure how that's supposed to be.

…18.3

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23218.3
…19.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23206.5 -> To Version 7.0.0-preview.23219.1
@joeloff joeloff merged commit 2cb2c1b into main Apr 19, 2023
@joeloff joeloff deleted the darc-main-25a3e9b6-c403-4df0-a83a-a14137fa6aa6 branch April 19, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants