Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET] Remove versions from baselines (#29093) #29120

Merged

Conversation

javiercn
Copy link
Member

  • Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest.
  • Removes all the versions and hashes from all the files Wed generate.
  • Splits the code for generating and comparing the baselines into their own classes for better maintenance.
  • Updates the baselines to reflect the new format.

* Updates the way the baselines are compared to generate
  a template of the baselines from the current manifest
  and compare it against the existing template instead of
  applying the current versions to the baseline and comparing
  it against the generated manifest.
* Removes all the versions and hashes from all the files Wed
  generate.
* Splits the code for generating and comparing the baselines
  into their own classes for better maintenance.
* Updates the baselines to reflect the new format.
@dotnet-issue-labeler dotnet-issue-labeler bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Nov 18, 2022
@javiercn javiercn marked this pull request as ready for review November 18, 2022 15:12
@javiercn
Copy link
Member Author

We have to wait a bit to merge on this branch

@marcpopMSFT marcpopMSFT merged commit b549313 into release/6.0.1xx Nov 29, 2022
@marcpopMSFT marcpopMSFT deleted the javiercn/remove-versions-from-baselines-6100 branch November 29, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants