Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tests for Implicit RIDs and Libraries #28696

Merged

Conversation

nagilson
Copy link
Member

@nagilson nagilson commented Oct 20, 2022

As a follow-up to #28628, this PR responds to PR feedback for tests that we didn't manage to get ready in time, as it would have delayed builds too long and we needed to get the fix in ASAP. Confirmed that the new tests fail in both regards without the change and pass in both regards (library paths and RID properties are set correctly) in the new scenario. We could target it to 7.0.1xx but I think that's locked down atm.

Drafting until 7.0.1xx changes have merged into 7.0.2xx.
cc @dsplaisted

@dsplaisted
Copy link
Member

I think we can probably target this to 7.0.1xx. Test changes don't have to be approved. We would probably just have to wait until the branch is open in to merge the PR, to avoid triggering unwanted builds.

Co-authored-by: Daniel Plaisted <[email protected]>
@nagilson nagilson changed the base branch from release/7.0.2xx to release/7.0.1xx October 21, 2022 16:40
@nagilson nagilson marked this pull request as ready for review October 21, 2022 16:40
@nagilson nagilson changed the base branch from release/7.0.1xx to release/7.0.2xx November 3, 2022 19:20
@nagilson
Copy link
Member Author

nagilson commented Nov 3, 2022

Will pass once #28717 is merged. cc @dsplaisted to approve. Confirmed the test failed before and passes with the newer rid inference code.

@nagilson nagilson merged commit 00ddda7 into dotnet:release/7.0.2xx Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants