Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeIdentifiers Code Coverage + Implicit RuntimeIdentifiers (not just runtimeIdentifier) #28484

Merged

Conversation

nagilson
Copy link
Member

@nagilson nagilson commented Oct 11, 2022

Description

Resolves #28048, follow up to #27985
We can imply a runtime identifier even if RuntimeIdentifiers is added and add a test to show that this feature works with not just one RID but RuntimeIdentifiers. The RID here is used to publish the project which will then use runtime identifiers.

Customer Impact

Low, this makes it so projects using RuntimeIdentifiers don't need to specify a RuntimeIdentifier, but probably they did anyways. It is a cleaner solution to the one we put out for source build a while ago, but both solutions fix the issue. We are raising this because we're making changes to this file anyways for a much more severe break, which is #28628.

Regression

No.

Risk

Somewhere between low and medium, closer to low than medium.

Testing

We added a test to test the scenario that the previous fix... well, fixed, but we haven't run it through source-build who were the initial consumers that discovered the problem with how we handled RuntimeIdentifiers.

@nagilson
Copy link
Member Author

nagilson commented Oct 17, 2022

@dsplaisted Right now this is targeting 7.0.1xx which will go into GA IIRC; I know we weren't sure if we wanted to merge this into GA or not. Seems lower priority than the workloads issue you have atm. I'll wait to merge this until we get confirmation from someone. Seems mildly risky-ish.

@nagilson
Copy link
Member Author

nagilson commented Oct 18, 2022

Per our call, we need to make other changes to RID Inference so we decided to mark this as Servicing-Consider.

cc @dsplaisted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants