RuntimeIdentifiers Code Coverage + Implicit RuntimeIdentifiers (not just runtimeIdentifier) #28484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
approved these changes
Oct 17, 2022
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
|
@dsplaisted Right now this is targeting 7.0.1xx which will go into GA IIRC; I know we weren't sure if we wanted to merge this into GA or not. Seems lower priority than the workloads issue you have atm. I'll wait to merge this until we get confirmation from someone. Seems mildly risky-ish. |
|
Per our call, we need to make other changes to RID Inference so we decided to mark this as Servicing-Consider. cc @dsplaisted |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #28048, follow up to #27985
We can imply a runtime identifier even if
RuntimeIdentifiersis added and add a test to show that this feature works with not just one RID butRuntimeIdentifiers. The RID here is used to publish the project which will then use runtime identifiers.Customer Impact
Low, this makes it so projects using RuntimeIdentifiers don't need to specify a RuntimeIdentifier, but probably they did anyways. It is a cleaner solution to the one we put out for source build a while ago, but both solutions fix the issue. We are raising this because we're making changes to this file anyways for a much more severe break, which is #28628.
Regression
No.
Risk
Somewhere between low and medium, closer to low than medium.
Testing
We added a test to test the scenario that the previous fix... well, fixed, but we haven't run it through source-build who were the initial consumers that discovered the problem with how we handled RuntimeIdentifiers.