-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blazor SWA Baseline Mismatched Assets Logging #27542
Conversation
src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but would it be more likely to avoid rot if it was pasted into AspNetSdkBaselineTest.cs and instructions directed there instead?
src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make sure we are getting the desired outcome before moving forward with the changes.
We should also just put a link to the wiki with the appropriate instructions (there is a script to deal with it now in one go)
Also added some more instructions to make this more actionable: e585f49 |
There isn't a great way to have super customized error message with fluent assertions, but after playing around with it a bit, I'm getting the following. Same number of manifest assets, `AssetTraitValue` property differs on one asset:
Same number of manifest assets, `AssetTraitValue` property differs on **all** assets:
Different number of manifest assets:(just did a skip 2)
|
* Add Blazor AssetDifferencesDetails * Update AspNetSdkBaselineTest.cs For https://github.com/dotnet/sdk/issues/27346 * Spacing * Create blazor-swa-baseline-generation.md * PR Feedback * Remove instructions add script reference * Property level comparison * Added instructions * Update AspNetSdkBaselineTest.cs * Update AspNetSdkBaselineTest.cs (cherry picked from commit bacc17c)
* Add Blazor AssetDifferencesDetails * Update AspNetSdkBaselineTest.cs For https://github.com/dotnet/sdk/issues/27346 * Spacing * Create blazor-swa-baseline-generation.md * PR Feedback * Remove instructions add script reference * Property level comparison * Added instructions * Update AspNetSdkBaselineTest.cs * Update AspNetSdkBaselineTest.cs (cherry picked from commit bacc17c)
* Add Blazor AssetDifferencesDetails * Update AspNetSdkBaselineTest.cs For https://github.com/dotnet/sdk/issues/27346 * Spacing * Create blazor-swa-baseline-generation.md * PR Feedback * Remove instructions add script reference * Property level comparison * Added instructions * Update AspNetSdkBaselineTest.cs * Update AspNetSdkBaselineTest.cs (cherry picked from commit bacc17c)
…Logging (#28894) * Add Blazor SWA Baseline Mismatched Assets Logging (#27542) * Add Blazor AssetDifferencesDetails * Update AspNetSdkBaselineTest.cs For https://github.com/dotnet/sdk/issues/27346 * Spacing * Create blazor-swa-baseline-generation.md * PR Feedback * Remove instructions add script reference * Property level comparison * Added instructions * Update AspNetSdkBaselineTest.cs * Update AspNetSdkBaselineTest.cs (cherry picked from commit bacc17c) * Create update-test-baselines.ps1
Fixes: dotnet/aspnetcore#43834