Support for msbuild/build event #26427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
baronfel
approved these changes
Jul 5, 2022
Member
baronfel
left a comment
baronfel
left a comment
There was a problem hiding this comment.
Seems pretty straightforward - glad that it was easy to plumb through here.
baronfel
reviewed
Jul 6, 2022
This reverts commit d90bd28.
rokonec
commented
Jul 9, 2022
Member
|
Anything blocking us from merging this @rokonec? |
marcpopMSFT
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for telemetry emitted by dotnet/msbuild#7778
This telemetry is supposed to be sent with every build, including base measurements and properties usable to understand usage of MSBuild.
This PR also fixes bug causing not sending telemetry from msbuild - introduced during changes of SDK calling msbuild.dll inproc.
NOTE: Although it is related to MSBuild server it could be merged into SDK before MSBuild server is released.