Fix issue where ASP.NET PackageReferences with implicit versions had incorrect PrivateAssets value #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incorrect PrivateAssets value
|
See NuGet/Home#7399 which would add a warning for cases like this. |
|
Is master the right branch here, or do we need it in an earlier release? |
|
@Pilchie Yes, I had the branch wrong. This should go into 2.2.1xx (and hence doesn't need to be approved for VS 15.9) |
|
@dotnet-bot test OSX10.12 Release |
livarcocc
approved these changes
Oct 12, 2018
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…0190904.1 (#2581) - Microsoft.NETCore.App - 5.0.0-alpha1.19454.1 Dependency coherency updates - System.CodeDom - 5.0.0-alpha1.19453.11 (parent: Microsoft.NETCore.App) - System.Security.Cryptography.ProtectedData - 5.0.0-alpha1.19453.11 (parent: Microsoft.NETCore.App) - System.Text.Encoding.CodePages - 5.0.0-alpha1.19453.11 (parent: Microsoft.NETCore.App)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2533, I set the
PrivateAssetsmetadata for ASP.NET CorePackageReferencestotrue, when it should have beenall. (This is what it was when the logic was in the web SDK: https://github.com/aspnet/websdk/blob/ee152187bf59ef13e214b8329773a81da66e5e47/src/Web/Microsoft.NET.Sdk.Web.Targets/Sdk.DefaultItems.targets#L132)This would cause a failure if a project that didn't have an ASP.NET Core PackageReference referenced one that did. The .props file from the package which set the
MicrosoftNETPlatformLibraryto the ASP.NET package would then flow, causing a failure in the referencing project's GenerateDepsFile task.FYI @natemcmaster