Remove reference to PlatformAbstractions #22254
Conversation
This is causing an unnecessary file to be shipped in the Sdk.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
Looks good, but let's wait until after 6.0.100 ships for this.
Sounds good to me. I put |
|
@dsplaisted @marcpopMSFT - is the branch open for servicing changes? If so, I believe this can be merged, and #22281 could be fixed. |
|
@eerhardt I've marked it as servicing-consider. Could you fill out the servicing template? |
Done. |
|
You can send mail to tactics for approval or come to tactics tomorrow. |
|
Approved for Dec - 6.0.1. |
|
@dsplaisted @marcpopMSFT - am I supposed to merge this PR? Or does someone on the "servicing team" merge it? (NOTE: In dotnet/runtime, the servicing PRs are merged by a specific team. So I'm not sure on the responsibilities.) |
|
Sorry, I think we missed the window for this for December. I probably should have merged it. Merging it now for the next servicing release. |
Looks like this probably actually will make it into December servicing. |
|
Nice, and thank you to everyone for your hard work with improving .NET one servicing/major release at a time. 😉 |
5 participants
This is causing an unnecessary file to be shipped in the Sdk.
Customer impact
During source-build, we no longer build this PlatformAbstractions assembly. It is no longer apart of a repo that is built in our product. To make this reference work in source-build, we are shipping a "ref assembly" built from https://github.com/dotnet/source-build-reference-packages. Thus, in a source-built version of our product, this PlatformAbstractions assembly doesn't have any implementation in it - just
throw nullstatements.Removing the reference means it is no longer being shipped in the product (neither Microsoft-distributed or source-build).
Regression
No.
Risk
Low. No one is using this assembly, so not referencing it shouldn't cause problems.