Update BlazorWebAssembly targets to work with updated wasm targets #21022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This PR](dotnet/runtime#57556) adds support for relinking the native wasm files during the build (instead of only during publish). This required changes to the targets available, and how they can be used, and thus require changes in the blazor targets to work with that. The new setup is explained in https://github.com/radical/runtime/blob/wasm-build/src/mono/wasm/build/README.md . Forward ports the changes from release/6.0.1xx
dotnet-issue-labeler
bot
added
the
Area-AspNetCore
|
Could I get @javiercn to review this? He's much more familiar with the WASM SDK than I am. |
|
@javiercn I cherrypicked the fix that was added in rc2, since it's all related. |
|
@javiercn Could you please review this with the cherry picked commit? |
javiercn
approved these changes
Sep 23, 2021
That's on me. You did sign-off, but then I added the short fix that was pushed to rc2, and so I asked for the review again! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
relinking the native wasm files during the build (instead of only during
publish).
This required changes to the targets available, and how they can be
used, and thus require changes in the blazor targets to work with that.
The new setup is explained in
https://github.com/radical/runtime/blob/wasm-build/src/mono/wasm/build/README.md .
Forward ports the changes from release/6.0.1xx