Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 36d72a60-4138-4c9e-24d5-08d9158524d7
  • Build: 20210520.4
  • Date Produced: 5/20/2021 6:10 PM
  • Commit: 1e347d3e229cf388249d342c72a1222bff0b5fdd
  • Branch: refs/heads/release/dev17.0-preview1-vs-deps

…520.4

Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset , Microsoft.CodeAnalysis.Workspaces.MSBuild
 From Version 4.0.0-1.21269.24 -> To Version 4.0.0-1.21270.4
@ghost
Copy link

ghost commented May 20, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro dotnet-maestro bot merged commit 3641de2 into release/6.0.1xx-preview5 May 20, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0.1xx-preview5-e7e78f0a-bb7b-4e04-83f8-ec598683334c branch May 20, 2021 19:46
v-wuzhai pushed a commit that referenced this pull request Apr 22, 2024
…l and its dependencies (#17750)" (#19112)

This reverts commit ec0971c.

Fixes [AB#1994786](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1994786/)

The MSBuild change which took advantage of this was reverted in 17.9 because it introduced issues in installations that don't have the .NET SDK component installed. We are fixing the bug in 9.0 by making changes to the dependencies of `Microsoft.DotNet.MSBuildSdkResolver` (see #39573) so this should stay in main. I am reverting it only in 8.0.3xx / 17.10 to fix the `Build_Ngen_InvalidAssemblyCount` counter which was flagged as a regression by PerfDDRITs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant