Code from roslyn-analyzers is missing PR and commit history

[xtqqczze]

Would it be possible to add the repository name to the pull request numbers in the commit messages? Or add a "commit migrated from" trailer like in dotnet/runtime@e8859b4.

@ViktorHofer I think it was an unfortunate oversight not to include the suggested changes.

As a result, this has led to a significant loss of metadata, all GitHub Issue and Pull Request links from roslyn-analyzers are now permanently broken within the IDE. Unfortunately, there’s no way to recover the original references, since issue and PR numbers collide between repositories.

Originally posted by @xtqqczze in #50167 (comment)

[KalleOlaviNiemitalo]

In principle, the information could still be added as git notes.

@xtqqczze, when you write "broken within the IDE", which IDE do you mean?

[xtqqczze]

when you write "broken within the IDE", which IDE do you mean?

This is a screenshot from vscode. Note that the link to PR 6675 is wrong.

[xtqqczze]

In principle, the information could still be added as git notes.

git notes don't seem to be widely supported, least of all on GitHub.

[KalleOlaviNiemitalo]

git replace would be an alternative. Reimport the commits, patching the commit messages this time, and push to a separate branch. Explain in README how to run git replace to start using the new import.

[KalleOlaviNiemitalo]

It looks like this import lost some history altogether. Compare these two commits titled "Trim the file paths to work around the long path errors. This can be reverted once we move our CI to use VS2019 machine pool."

• dotnet/roslyn-analyzers@d9ee800 moved files from src/Microsoft.CodeAnalysis.NetAnalyzers/ to src/NetAnalyzers/.
  For example, src/Microsoft.CodeAnalysis.NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Performance/CSharpDoNotUseCountWhenAnyCanBeUsed.Fixer.cs was moved to src/NetAnalyzers/CSharp/Microsoft.NetCore.Analyzers/Performance/CSharpDoNotUseCountWhenAnyCanBeUsed.Fixer.cs and had four other commits before that.
• 5be635f instead added files to src/Microsoft.CodeAnalysis.NetAnalyzers/.
  For example, src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.CSharp.NetAnalyzers/Microsoft.NetCore.Analyzers/Performance/CSharpDoNotUseCountWhenAnyCanBeUsed.Fixer.cs is a new file there, with no earlier commits.

As another example, dotnet/roslyn-analyzers@40e5146 "Handle Interlocked.Exchange and Interlocked.CompareExchange operations" has no equivalent in the dotnet/sdk repository, even though AvoidDeadConditionalCode_ValueContentAnalysis.cs is included.

• History of AvoidDeadConditionalCode_ValueContentAnalysis.cs in dotnet/roslyn-analyzers continues across multiple renames:
  • src/Microsoft.CodeAnalysis.NetAnalyzers/UnitTests/Microsoft.CodeQuality.Analyzers/Maintainability/AvoidDeadConditionalCode_ValueContentAnalysis.cs
  • src/Microsoft.CodeQuality.Analyzers/UnitTests/Maintainability/AvoidDeadConditionalCode_ValueContentAnalysis.cs
  • src/Microsoft.CodeQuality.Analyzers/UnitTests/Maintainability/AvoidDeadConditionalCode_StringContentAnalysis.c
  • src/Microsoft.CodeQuality.Analyzers.Exp/UnitTests/Maintainability/AvoidDeadConditionalCode_StringContentAnalysis.cs
• History of AvoidDeadConditionalCode_ValueContentAnalysis.cs in dotnet/sdk ends at 5be635f

[xtqqczze]

It looks like this import lost some history altogether.

@ViktorHofer PTAL

[marcpopMSFT]

CC @phil-allen-msft