NETSDK1204 error during dotnet clean on macOS when AoT enabled

[martincostello]

Describe the bug

Running dotnet clean as part of the Polly CI fails on macOS when PublishAot=true is specified in a project file.

To Reproduce

Run build.ps1 on macOS after cloning this commit: App-vNext/Polly@58c807e

I haven't been able to reproduce this in a simpler project: martincostello/dotnet-8-samples#10

I also don't have access to a macOS computer (I have a Windows laptop), so I can't test this out locally to try and get a more minimal repro.

Exceptions (if any)

Workflow error logs from App-vNext/Polly#1800:

Error: /Users/runner/.dotnet/sdk/8.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1204: Ahead-of-time compilation is not supported on the current platform 'osx-x64'. [/Users/runner/work/Polly/Polly/test/Polly.AotTest/Polly.AotTest.csproj]

Further technical details

.NET 8.1.00 SDK running on GitHub Action's macos-latest runner.

[eerhardt]

FYI- @sbomer @agocke

[sbomer]

@martincostello The project is targeting net7.0 which did not support PublishAot for osx-x64. The .NET 8 SDK has improved error handling for unsupported scenarios. Would you be able to update the project to targcet net8.0?

[sbomer]

For future reference, I was able to get a binlog out of this with the following change to build.cake:

 var dotNetCleanSettings = new DotNetCleanSettings
         {
             Verbosity = DotNetVerbosity.Minimal,
+            MSBuildSettings = new DotNetMSBuildSettings
+            {
+                BinaryLogger = new MSBuildBinaryLoggerSettings
+                {
+                    Enabled = true,
+                    FileName = System.IO.Path.Combine(artifactsDir, Directory("msbuild.binlog")),
+                },
+            },
         };

The error is happening because the net7.0 KnownILCompilerPacks doesn't include a RID for osx-x64 (since that's not supported). I don't have an x64 macOS machine to test on, but I get the same error on osx-arm64 when targeting net7.0.

[martincostello]

I'm quite confused because we've updated our SDK to 8.0 and added net8.0 targets. Did we miss a 7.0 reference somewhere?

[sbomer]

I'm looking at the TFM of the test project in the commit you shared: App-vNext/Polly@58c807e#diff-a9aede301b3d3343182c1aac4a69b05e602be40e498b5295ad94735ea344f70eR8

[martincostello]

Ah. That project was added subsequent to the initial .NET 8 PR being opened so it must have missed our 7.0 find and replace sweep 🤦🏻‍♂️