Skip to content

Bound post-kill WaitForExit to prevent scenario-test hangs #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mthalman merged 1 commit into from
Jul 31, 2026
Merged

Bound post-kill WaitForExit to prevent scenario-test hangs #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Microsoft.DotNet.ScenarioTests.Common/ExecuteHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ namespace Microsoft.DotNet.ScenarioTests.Common;

public static class ExecuteHelper
{
// Grace period to wait for a killed process tree to fully exit. A parameterless
// WaitForExit() after Kill(true) blocks until the redirected stdout/stderr pipes
// reach EOF; a surviving grandchild (e.g. the web app spawned by `dotnet run`) that
// inherited those handles can keep them open indefinitely, hanging the test until the
// pipeline task timeout. Bounding the wait lets the run fail fast instead.
public const int KillGraceMilliseconds = 30_000;

public static (Process Process, string StdOut, string StdErr) ExecuteProcess(
string fileName,
string args,
Expand Down Expand Up @@ -63,7 +70,11 @@ public static (Process Process, string StdOut, string StdErr) ExecuteProcess(
{
outputHelper.WriteLine($"Killing: {fileName} {args}");
process.Kill(true);
process.WaitForExit();
if (!process.WaitForExit(KillGraceMilliseconds))
Comment thread
mthalman marked this conversation as resolved.
{
outputHelper.WriteLine("Process tree did not fully exit within the kill grace period; " +
"abandoning wait to avoid hanging on inherited stdout/stderr handles.");
}
ProcessStartInfo startInfo = process.StartInfo;
string msg = $" {startInfo.FileName} {startInfo.Arguments} timed out after " +
$"{millisecondTimeout} milliseconds" +
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ void processConfigCallback(Process process)
if (e.Data?.Contains("Application started. Press Ctrl+C to shut down.") ?? false)
{
process.Kill(true);
process.WaitForExit();
process.WaitForExit(ExecuteHelper.KillGraceMilliseconds);
}
});
}
Expand Down Expand Up @@ -276,7 +276,7 @@ async void processConfigCallback(Process process)
await Task.Delay(5000);
}
TerminateProcess(process.Handle, 0);
process.WaitForExit();
process.WaitForExit(ExecuteHelper.KillGraceMilliseconds);
}

bool checkProcess(string projectDirectory, Process process)
Expand Down