Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic implementation of the ComWrappers #653

Merged
merged 58 commits into from
Apr 21, 2021
Merged

Add basic implementation of the ComWrappers #653

merged 58 commits into from
Apr 21, 2021

Commits on Feb 18, 2021

  1. Add basic implementation of the ComWrappers

    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    28bf64b View commit details
    Browse the repository at this point in the history

  2. Fixes after refactoring in dotnet/runtime

    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    d8daea1 View commit details
    Browse the repository at this point in the history

  3. Rough attempt to move forward. Attempt to create CCW

    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3328c6d View commit details
    Browse the repository at this point in the history

  4. Slight push toward CCW. 

    I have 2 ideas. CCW seems to be rathe rcompilcated. But RCW require just having Dictionary<IntrPtr, object> to keep track of RCWs. Most likely this should be some weekly referenced object, which should release COM object when no longer referenced. In fnalizer probably.
    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b328e48 View commit details
    Browse the repository at this point in the history

  5. Move configuration for FeatureComWrappers outside of project file

    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f8165c6 View commit details
    Browse the repository at this point in the history

  6. More implementation for the MOW

    @kant2002
    kant2002 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    fb2233f View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Slightly more changes based on feedback. 

    More types for memory layout.
    @kant2002
    kant2002 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    e35695b View commit details
    Browse the repository at this point in the history

  2. Delagate IUnknown implementation to MOW

    @kant2002
    kant2002 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    868b1bf View commit details
    Browse the repository at this point in the history

  3. Implement IUnknown interface for CCW

    @kant2002
    kant2002 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    017e907 View commit details
    Browse the repository at this point in the history

  4. Return proper pointer to IUnknown

    @kant2002
    kant2002 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    d4e3188 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtim… 

    …e/InteropServices/ComWrappers.CoreRT.cs

Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    3d5867c View commit details
    Browse the repository at this point in the history

  2. Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtim… 

    …e/InteropServices/ComWrappers.CoreRT.cs

Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    dd7ebdd View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    f03e3c8 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    b2b33ff View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Feb 20, 2021
    Configuration menu
    Copy the full SHA
    75145a8 View commit details
    Browse the repository at this point in the history

  6. Address PR feedback

    @kant2002
    kant2002 committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    ac4d949 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Cleanup code

    @kant2002
    kant2002 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    fa87e37 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @kant2002
    kant2002 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8c89b5a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    3aafcd6 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Fix compilation errrors 

    Except one with ComInterfaceDispatch
    @kant2002
    kant2002 committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    72da0c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Introduce InternalComInterfaceDispatch

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3c93e34 View commit details
    Browse the repository at this point in the history

  2. Reuse variable

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b1dfda4 View commit details
    Browse the repository at this point in the history

  3. Delegate conversion of runtime object to COM object to ComWrappers in… 

    …frastructure
    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c4dca94 View commit details
    Browse the repository at this point in the history

  4. Change message when ComWrappers are required.

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    367e5f4 View commit details
    Browse the repository at this point in the history

  5. Attempt to fix compilation error.

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7577418 View commit details
    Browse the repository at this point in the history

  6. Minimal amount of working COM

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2fead1d View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c7a5d1e View commit details
    Browse the repository at this point in the history

  8. Update src/coreclr/tools/Common/TypeSystem/IL/Stubs/PInvokeILEmitter.cs

    @jkotas
    jkotas authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    08d92c2 View commit details
    Browse the repository at this point in the history

  9. Apply code review suggestions

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3e8a8c2 View commit details
    Browse the repository at this point in the history

  10. Apply code review suggestions

    @kant2002
    kant2002 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d9a65a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Add tests for the CCW release process

    @kant2002
    kant2002 committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c06f5e2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    577f34a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Fix compilation errors

    @kant2002
    kant2002 committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    ae0c824 View commit details
    Browse the repository at this point in the history

  2. Remove Destroyed field from MOW

    @kant2002
    kant2002 committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    a36de92 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Ignore COM related functions in native tests code

    @kant2002
    kant2002 committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    7ee193a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Fix random crash on debug builds. 

    I wish that BCL or runtime has primitives like fixed size heap arrays.
    @kant2002
    kant2002 committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    70dd962 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    847a68e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    0cf1003 View commit details
    Browse the repository at this point in the history

  2. Add validation of call for DoWork

    @kant2002
    kant2002 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    479e306 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Fix PR feedback

    @kant2002
    kant2002 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    62acb0b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Switch to COM interface

    @kant2002
    kant2002 committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    b021ef8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Pass type to which convert COM instance.

    @kant2002
    kant2002 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    7abba2f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Create separate tests for ComWrappers feature

    @kant2002
    kant2002 committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    3b2848a View commit details
    Browse the repository at this point in the history

  2. Fix Pinvoke name of the DLL with test functions

    @kant2002
    kant2002 committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    87213bb View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2021

  1. Fix code review comments

    @kant2002
    kant2002 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    acfaca8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. Remove incomplete PreserveSig implementation

    @kant2002
    kant2002 committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    ecbd14e View commit details
    Browse the repository at this point in the history

  2. Update src/tests/nativeaot/SmokeTests/ComWrappers/ComWrappers.cs 

    Co-authored-by: Michal Strehovský <[email protected]>
    @kant2002 @MichalStrehovsky
    kant2002 and MichalStrehovsky authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    3dce725 View commit details
    Browse the repository at this point in the history

  3. Update src/tests/nativeaot/SmokeTests/ComWrappers/ComWrappers.cs 

    Co-authored-by: Michal Strehovský <[email protected]>
    @kant2002 @MichalStrehovsky
    kant2002 and MichalStrehovsky authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    359c53d View commit details
    Browse the repository at this point in the history

  4. Update src/tests/nativeaot/SmokeTests/ComWrappers/ComWrappers.csproj 

    Co-authored-by: Michal Strehovský <[email protected]>
    @kant2002 @MichalStrehovsky
    kant2002 and MichalStrehovsky authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    e761497 View commit details
    Browse the repository at this point in the history

  5. Update src/tests/nativeaot/SmokeTests/ComWrappers/ComWrappers.cs 

    Co-authored-by: Michal Strehovský <[email protected]>
    @kant2002 @MichalStrehovsky
    kant2002 and MichalStrehovsky authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    5a6d6eb View commit details
    Browse the repository at this point in the history

  6. Fix compilation errors

    @kant2002
    kant2002 committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    716d585 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Read GUID directly from metadata instead of relying on Reflection

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    218a300 View commit details
    Browse the repository at this point in the history

  2. Remove leftover

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    e7b0b59 View commit details
    Browse the repository at this point in the history

  3. Improve GUID creation

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    bdba4ea View commit details
    Browse the repository at this point in the history

  4. Fix stupid compilation error

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1db71ff View commit details
    Browse the repository at this point in the history

  5. Add missing using

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2f826ce View commit details
    Browse the repository at this point in the history

  6. Another round of stupidity

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    0b90983 View commit details
    Browse the repository at this point in the history

  7. One more try

    @kant2002
    kant2002 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f9acd5c View commit details
    Browse the repository at this point in the history