Json source generation logic #53

kevinwkt · 2020-08-12T21:31:34Z

A few things in this PR:

Changed impl for dfs usage for better error handling (updated user facing error messages and made them as a singleton).
Used Steve's new API and updated tests to use sourcegenerated code for (de)serialization.
Created base source generation logic for simple pocos and collections (for the ones we support right now in System.Text.Json.Serializer.Metadata)
Extension methods for typewrapper for full namespace detection and interface checks (e.g. IEnumerable, IList, etc).
Tests for user-facing diagnostics.

layomia

Will review generation logic shortly.

...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/TypeWrapperTests.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs

…or helper

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs

src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/ReflectionUtils/TypeWrapper.cs

layomia

LGTM

This fixes a bug in the openssl selfsign code where it's buffer was too small for the strings copied into it.

kevinwkt added 3 commits August 11, 2020 20:19

Initial prototype using dfs and checking for cycles

b97c362

Resolve merge conflicts from upstream

5c5ccf7

Polish debugging and fix tests

7f187ce

kevinwkt added the area-JsonCodeGen label Aug 12, 2020

kevinwkt requested a review from layomia August 12, 2020 21:31

layomia reviewed Aug 13, 2020

View reviewed changes

layomia reviewed Aug 14, 2020

View reviewed changes

kevinwkt added 5 commits August 14, 2020 09:05

Update tests and change accessibility for variables for sourcegenerat…

6ab1c73

…or helper

Add unit tests for diagnostics for users

1c04f25

Move info logs to only successful generation

fe79a83

Get rid of cycle check for next pr

cf1f266

Get rid of stack logic for cycle checks

8038eb3

kevinwkt marked this pull request as ready for review August 16, 2020 00:25

kevinwkt requested review from steveharter and jozkee August 16, 2020 00:25

Cache property values for typewrapper methods

d773fb5