-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json source generation logic #53
Merged
kevinwkt
merged 13 commits into
dotnet:JsonCodeGen
from
kevinwkt:JsonSourceGenerationLogic
Aug 20, 2020
Merged
Json source generation logic #53
kevinwkt
merged 13 commits into
dotnet:JsonCodeGen
from
kevinwkt:JsonSourceGenerationLogic
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
reviewed
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review generation logic shortly.
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/TypeWrapperTests.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Show resolved
Hide resolved
layomia
reviewed
Aug 14, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
kevinwkt
commented
Aug 18, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
layomia
reviewed
Aug 19, 2020
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/ReflectionUtils/TypeWrapper.cs
Outdated
Show resolved
Hide resolved
layomia
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
scalablecory
pushed a commit
that referenced
this pull request
Sep 22, 2020
This fixes a bug in the openssl selfsign code where it's buffer was too small for the strings copied into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in this PR: