Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Include JS interop generator in ILC package #2573

Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented May 4, 2024

  • Include JS interop generator in ILC package
  • Replace the one from TargetingPack
  • Packages validated locally

Contributes to #2434

@maraf maraf added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label May 4, 2024
@maraf maraf self-assigned this May 4, 2024
@@ -9,6 +9,11 @@
<Content Include="*.*" Exclude="$(MSBuildProjectFile)" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="$(LibrariesProjectRoot)\System.Runtime.InteropServices\gen\Microsoft.Interop.SourceGeneration\Microsoft.Interop.SourceGeneration.csproj" OutputItemType="Analyzer" />
Copy link
Member Author

@maraf maraf May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger How can I do something this in here? I need to be sure that the interop generator is built before this project's Build target

@maraf maraf requested review from akoeplinger and a team May 6, 2024 12:54
@maraf maraf marked this pull request as ready for review May 6, 2024 12:54
Copy link

@SingleAccretion SingleAccretion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a request for a new issue to link to. Thank you!

@maraf maraf merged commit d2b3139 into dotnet:feature/NativeAOT-LLVM May 7, 2024
11 checks passed
@maraf maraf deleted the bundle-jsinterop-analyzer branch May 7, 2024 07:38
@akoeplinger
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants