Implement ComWrappers.RegisterForTrackerSupport to be able create CCW #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves a bit towards dotnet#306 and dotnet#1453
jkotas
reviewed
Sep 9, 2021
...lr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.CoreRT.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 9, 2021
...lr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.CoreRT.cs
Outdated
Show resolved
Hide resolved
…e/InteropServices/ComWrappers.CoreRT.cs Co-authored-by: Jan Kotas <[email protected]>
jkotas
reviewed
Sep 9, 2021
...lr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.CoreRT.cs
Show resolved
Hide resolved
…e/InteropServices/ComWrappers.CoreRT.cs
jkotas
reviewed
Sep 9, 2021
| @@ -364,6 +489,9 @@ public object GetOrRegisterObjectForComInstance(IntPtr externalComObject, Create | |||
| if (flags.HasFlag(CreateObjectFlags.Aggregation)) | |||
| throw new NotImplementedException(); | |||
|
|
|||
| if (flags.HasFlag(CreateObjectFlags.TrackerObject)) | |||
There was a problem hiding this comment.
Just to make sure that I understand this right: This blocks the newly added code from getting executed for now. Is that correct?
There was a problem hiding this comment.
I implement only CCW. I thought that throw that for RCW was a right way, but if I remove that lines, then app from #1453 is basically working (except it does not produce any Toast for me). But exit code == 0. So I would remove these lines, and let it leak. At least you wasn't agains that previously.
Closed
jkotas
reviewed
Sep 9, 2021
...lr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.CoreRT.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a bit towards #306 and #1453