Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement handling PreserveSig = false for interfaces #1206

Merged
merged 9 commits into from
Jun 8, 2021
Merged

Implement handling PreserveSig = false for interfaces #1206

merged 9 commits into from
Jun 8, 2021

Commits on Jun 7, 2021

  1. Implement handling PerserveSig = false for interfaces 

    This was done by pretending return value is out argument passed as last value.
We still need to return that value, so this require change in the Marshaller.cs so it would not throw assertion, since previously only Return values can return value.
    @kant2002
    kant2002 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ba68a4b View commit details
    Browse the repository at this point in the history

  2. Ignore delegating marshalling thunks

    @kant2002
    kant2002 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f614212 View commit details
    Browse the repository at this point in the history

  3. I add special case for handling blittable types which are return type… 

    … for PreserveSig=false methods. In this case I fallback to default marshalling implementation.
    @kant2002
    kant2002 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    15a5c68 View commit details
    Browse the repository at this point in the history

  4. Remove artificial constraing on PreserveSig=false

    @kant2002
    kant2002 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    48de7aa View commit details
    Browse the repository at this point in the history

  5. Address PR feedback

    @kant2002
    kant2002 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    0b5bb1c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Fix

    @kant2002
    kant2002 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    dbdb239 View commit details
    Browse the repository at this point in the history

  2. Add simple tests for PreservSig=false functionality

    @kant2002
    kant2002 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5903921 View commit details
    Browse the repository at this point in the history

  3. Update src/coreclr/tools/Common/TypeSystem/Interop/IL/Marshaller.cs 

    Co-authored-by: Jan Kotas <[email protected]>
    @kant2002 @jkotas
    kant2002 and jkotas authored Jun 8, 2021
    Configuration menu
    Copy the full SHA
    df9bdb1 View commit details
    Browse the repository at this point in the history

  4. Reformat code based on PR feedback

    @kant2002
    kant2002 committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5e098f6 View commit details
    Browse the repository at this point in the history