[release/8.0-staging] fix SendTo with SocketAsyncEventArgs #99695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl |
antonfirsov
approved these changes
Mar 19, 2024
karelz
approved these changes
Mar 26, 2024
|
It is a regression in 8.0, preventing customers to send data where they want. We should fix it. |
wfurt
added
Servicing-approved
|
approved via email |
|
test failure is unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #98134 to release/8.0-staging
Fixes #97965 and #99863 -- a regression from PR #90086 (in 8.0).
/cc @wfurt
Customer Impact
This is regression caused by 8.0 changes (PR #90086). Traditionally it is possible to use
SocketAsyncEventArgsmultiple times but that no longer works forSendTomethod. Starting with 8.0 we either fail to send the data or we can send them to wrong endpoint which leads to privacy concerns.Reported by 2 external customers in #97965 and #99863
Regression
Yes, introduced by PR #90086
Testing
Added targeted test case for reusing
SocketAsyncEventArgswithSendTomethod.Validated by a customer on 9.0 build with the fix.
Risk
Small - scoped only to UDP code path using
SocketAsyncEventArgs(Task-based and synchronous code paths are OK) ... which is a rarely used combo.The fix is relatively small and the issue is fully understood.