Upgrade zlib to 1.3.1 #99472
Merged
Upgrade zlib to 1.3.1 #99472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"implicit-int-conversion" warning The change to deflate.c is legal because 'len' has an upper bound of MAX_STORED, which means it fits cleanly into a 16-bit integer. So writing out 2x 8-bit values will not result in data loss. The change to trees.c is legal because within this loop, 'count' is intended to have an upper bound of 138, with the target assignment only executing if 'count' is bounded by 4. Neither the 'count' local in isolation nor the addition that's part of the target line is expected to result in integer overflow. But even if it did, that's a matter for a different warning code and doesn't impact the correctness of the narrowing cast being considered here. Author: Levi Broderick <[email protected]>
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
GrabYourPitchforks
approved these changes
Mar 9, 2024
jkotas
reviewed
Mar 9, 2024
carlossanlop
commented
Mar 11, 2024
GrabYourPitchforks
approved these changes
Mar 11, 2024
This was referenced Mar 11, 2024
|
@ericstj @GrabYourPitchforks @artl93 Edit: Rerunning perf in a Windows arm64 machine, I ran it in x64 and that uses zlib-intel... |
|
@ericstj @GrabYourPitchforks @artl93 here are the results in Windows arm64, which actually consumes zlib (not zlib-intel). There wasn't any significant perf difference. Note that new is top, base is bottom:
|
|
Looks good. We can also double-check the results from the perf-lab since this is merged now. Looks like we have some ZLIB benchmarks that will run on more platforms. I think that's https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/TestHistoryIndexIndex.html |
|
Sure, I can also check those results. First I need to understand if they get executed periodically in an automated way or if I need to execute them myself manually. Since the servicing branches are currently closed, would anyone object to merging the servicing PRs so they bake in staging until the branches open again? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.