[release/6.0] Add missing Evidence types to AcccessControl NETFramework Facade #99462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
|
The staging branches are currently open. Can you please retarget the PR to 6.0-staging? |
carlossanlop
approved these changes
Mar 8, 2024
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. Pending retargeting to the staging branch.
ViktorHofer
approved these changes
Mar 9, 2024
carlossanlop
added
Servicing-approved
Contributor
|
Approved by Tactics via email. Will make sure to include it in today's flow to base. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99447
Description
The AccessControl assembly is missing type forwards for
EvidenceandEvidenceBaseon .NETFramework.Customer Impact
Cannot use
EvidenceorEvidenceBasefrom a netstandard2.0 library and run on .NETFramework.At compile time will see:
At runtime will see:
Regression
Yes, from 5.0 packages. See issue for RCA.
Testing
Manual, customer scenario + API Compat.
Risk
Very small. Simply adding type-forwards to the existing assembly.