Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP2 => HTTP/1.1 downgrade bookkeeping #99402

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

MihaZupan
Copy link
Member

Fixes #99401

Without the product change, the added test asserts here

Debug.Assert(_associatedHttp11ConnectionCount > _availableHttp11Connections.Count,
$"Expected _associatedHttp11ConnectionCount={_associatedHttp11ConnectionCount} > _availableHttp11Connections.Count={_availableHttp11Connections.Count}");

Process terminated. Assertion failed.
Expected _associatedHttp11ConnectionCount=1 > _availableHttp11Connections.Count=1
    at System.Net.Http.HttpConnectionPool.ReturnHttp11Connection

@MihaZupan MihaZupan added this to the 9.0.0 milestone Mar 7, 2024
@MihaZupan MihaZupan requested a review from a team March 7, 2024 09:37
@MihaZupan MihaZupan self-assigned this Mar 7, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub merged commit 80b1e14 into dotnet:main Mar 7, 2024
111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookkeeping bug in HttpConnectionPool when handling an HTTP/2 => HTTP/1.1 downgrade
4 participants