Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup comments and ifdefs around this_OFFSET_FLAG #99092

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Cleanup comments and ifdefs around this_OFFSET_FLAG #99092

merged 4 commits into from
Mar 1, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Feb 29, 2024

Contributes to
#35748 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 29, 2024
@ghost ghost assigned jkotas Feb 29, 2024
@ghost
Copy link

ghost commented Feb 29, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to
#35748 (comment)

Author: jkotas
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jkotas jkotas requested a review from VSadov February 29, 2024 01:44
@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 29, 2024
@ghost
Copy link

ghost commented Feb 29, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to
#35748 (comment)

Author: jkotas
Assignees: jkotas
Labels:

area-CodeGen-coreclr
Milestone: -

@jkotas jkotas mentioned this pull request Feb 29, 2024
Open
VSadov
VSadov approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build-analysis build-analysis bot mentioned this pull request Feb 29, 2024
Closed
jkotas
jkotas commented Feb 29, 2024
View reviewed changes
src/coreclr/inc/gcinfo.h Outdated Show resolved Hide resolved
jkotas
jkotas commented Feb 29, 2024
View reviewed changes
src/coreclr/jit/emit.cpp Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Feb 29, 2024
Closed
@jkotas jkotas mentioned this pull request Mar 1, 2024
Closed
@jkotas jkotas merged commit 9863bf1 into dotnet:main Mar 1, 2024
126 of 129 checks passed
@jkotas jkotas deleted the this_OFFSET_FLAG branch March 1, 2024 02:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VSadov VSadov VSadov approved these changes

@AndyAyersMS AndyAyersMS Awaiting requested review from AndyAyersMS

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @VSadov