Skip to content

[release/9.0-preview2] Revert "Support generic arguments for calli in CoreCLR (#97079)" #99016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

[release/9.0-preview2] Revert "Support generic arguments for calli in CoreCLR (#97079)" #99016

merged 1 commit into from
Feb 27, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Feb 27, 2024 •
edited
Loading

This reverts commit 15ff723.

Revert of #97079 in release/9.0-preview2

/cc @AaronRobinsonMSFT

Customer Impact

  • Customer reported
  • Found internally

Regression

  • Yes
  • No

Regression introduced by #97079. Breaks all CsWinRT scenarios.

Testing

New tests addressing the scenario will be added in main.

Risk

Low. Full revert of the change #97079

@ghost ghost assigned jkotas Feb 27, 2024
@ghost ghost added the area-Interop-coreclr label Feb 27, 2024
@jkotas jkotas changed the title Revert "Support generic arguments for calli in CoreCLR (#97079)" [release/9.0-preview2] Revert "Support generic arguments for calli in CoreCLR (#97079)" Feb 27, 2024
@jkotas
Copy link
Member Author

jkotas commented Feb 27, 2024

@carlossanlop Is there an approval process that this needs to go through?

This needs to be reverted in preview2. It breaks all CsWinRT scenarios.

@carlossanlop
Copy link
Contributor

Yes, we need Tactics approval for this.

Please fill out the template, add the servicing-consider label, send the email to Tactics requesting approval, and get the PR signed-off. I'll monitor it so that when it's ready, I'll merge it.

@jkotas jkotas added the Servicing-consider Issue for next servicing release review label Feb 27, 2024
carlossanlop
carlossanlop approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it's a revert. Just need to make sure the CI looks good before merging.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 27, 2024
@carlossanlop
Copy link
Contributor

Approved by Tactics via email. I'll wait for the basic runtime coreclr legs to finish and then will merge it.

@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Feb 27, 2024
@carlossanlop carlossanlop merged commit 50f7525 into dotnet:release/9.0-preview2 Feb 27, 2024
@jkotas jkotas deleted the revert-generic-calli branch February 27, 2024 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkotas jkotas

Labels

area-Interop-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas @carlossanlop @AaronRobinsonMSFT @jeffschwMSFT