-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Run tests in parallel #98492
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
|
This comment was marked as outdated.
This comment was marked as outdated.
|
This reverts commit 8bd31e8.
@@ -5,6 +5,9 @@ | |||
<IncludeRemoteExecutor>true</IncludeRemoteExecutor> | |||
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | |||
</PropertyGroup> | |||
<PropertyGroup Condition="'$(TargetOS)' == 'browser'"> | |||
<WasmXHarnessMaxParallelThreads>1</WasmXHarnessMaxParallelThreads> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem with buffers ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOM killed (from PR description)
[FAIL][8] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(requestedMinimum: 2097152, expectedLength: 2097152)
info: System.OutOfMemoryException : Out of memory
info: at System.Buffers.ConfigurableArrayPool`1[[System.String, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Rent(Int32 minimumLength)
info: at System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Int32 requestedMinimum, Int32 expectedLength)
info: at System.Object.InvokeStub_ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Object , Span`1 )
info: at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can re-parallelize them if you want to see the whole log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that GC is unable to keep up with the traffic. Let's create issue for that.
I wonder if Mono on x64 has the same problem but survives this because of more available memory ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #100628
/ba-g the failure is #95805 |
The other failure is #98964 |
Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Pavel Savara <[email protected]>
WasmXHarnessMaxParallelThreads