Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more bugs found with ILVerify #98393

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix more bugs found with ILVerify #98393

merged 3 commits into from
Feb 14, 2024

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Feb 13, 2024

  • For constructors populated from constructed generic type also need to load original ctor version
  • Incorrect token when unbaked TypeBuilder used as generic argument for generic method
  • Add MethodBuilderImpl.ReturnParameter implementation

Contributes to #92975

@ghost
Copy link

ghost commented Feb 13, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details
  • For constructors populated from constructed generic type also need to load original ctor version
  • Incorrect token when unbaked TypeBuilder used as generic argument for generic method
  • Add MethodBuilderImpl.ReturnParameter implementation

Contributes to #92975

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Emit

Milestone: -

…icParameters, check generic parameters instead, add related test
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@buyaa-n buyaa-n merged commit 72ee969 into dotnet:main Feb 14, 2024
179 checks passed
@buyaa-n buyaa-n deleted the fix-bug branch February 14, 2024 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants