Workaround arm32 remote unwind assert in createdump #98140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsCreatedump was hitting the assert in get_proc_name in the remote unwinder on arm32. The newer libunwind is calling this now. Working around the call by returning that there is no proc name for the address (return -ENW_ENOINFO).
|
mikem8361
force-pushed
the
arm32unwind
branch
from
edd6ca6
to
185b7e4
Compare
tommcdon
approved these changes
Feb 8, 2024
hoyosjs
approved these changes
Feb 8, 2024
This was referenced Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Createdump was hitting the assert in get_proc_name in the remote unwinder on arm32. The newer libunwind is calling this now. Working around the call by returning that there is no proc name for the address (return -ENW_ENOINFO).