Disable linker warning LNK4104 when building native AOT libraries #98084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link.exe hardcodes a list of magic symbol names that it thinks should not be generated into import library and emits warnings if they are.
We don't have a mechanism to set visibility of
UnmanagedCallersOnly
methods and I don't think we'd want to make a public API for that. But this means that users get a warning that is not particularly actionable. We could either replicate this magic list of symbol names into compiler and generate these asPRIVATE
(but then how do people opt out if they don't actually want this asPRIVATE
?), or we can just suppress the warning.This PR suppresses the warning.
Cc @dotnet/ilc-contrib @Sergio0694