-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported interleaving support to System.IO.Packaging #97898
Commits on Feb 2, 2024
-
Added interleaving support to System.IO.Packaging
This is essentially KevinCathcart's work, with a test suite and changes required to ensure that these tests pass.
Configuration menu - View commit details
-
Copy full SHA for e18c425 - Browse repository at this point
Copy the full SHA e18c425View commit details -
Removed reference to NuGet.Frameworks
Also removed other unused "using" statements.
Configuration menu - View commit details
-
Copy full SHA for c0b174a - Browse repository at this point
Copy the full SHA c0b174aView commit details
Commits on Feb 4, 2024
-
Removed use of string.CompareOrdinal when processing part pieces. Replaced byte allocations with ArrayPool Rent/Returns. Made InterleavedZipPackagePartStream use Spans instead of byte arrays. This has increased memory usage when .NET Framework calls Read(byte[], int, int) and Write(byte[], int, int).
Configuration menu - View commit details
-
Copy full SHA for 7d3217e - Browse repository at this point
Copy the full SHA 7d3217eView commit details
Commits on Feb 9, 2024
-
Adjusted the compilation conditions for Read
Split Read and ReadCore apart, so that a new Read(Span<byte>) method doesn't appear on the .NET Standard 2.0 path. Also adjusted the conditions from "NETCOREAPP2_1_OR_GREATER" to "!NETFRAMEWORK && !NETSTANDARD2_0", to align with the rest of .NET.
Configuration menu - View commit details
-
Copy full SHA for d873e1b - Browse repository at this point
Copy the full SHA d873e1bView commit details -
Moved the ArrayPool.Return calls into a finally block, for safety pur…
…poses I can't see a simple way to do this in the Write() path - we rent and return across some loop iterations
Configuration menu - View commit details
-
Copy full SHA for ca3ecfe - Browse repository at this point
Copy the full SHA ca3ecfeView commit details
Commits on Feb 19, 2024
-
Changes following second round of code review
* Corrections to comments and spacing. * Switched to the use of an EndOfStreamException in the correct situation. * Adjusted the SeekUnderlyingPieceStream method to slightly tweak the mechanism and to make use of a readBuffer which might be larger than BufferSize. * Small refactor of part piece deletion.
Configuration menu - View commit details
-
Copy full SHA for e921812 - Browse repository at this point
Copy the full SHA e921812View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d68f98 - Browse repository at this point
Copy the full SHA 1d68f98View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd6283b - Browse repository at this point
Copy the full SHA fd6283bView commit details -
This was only used to reference ZipPackagePartPiece.TryParse and .Index, so switched the tests to use reflection.
Configuration menu - View commit details
-
Copy full SHA for 80b2c48 - Browse repository at this point
Copy the full SHA 80b2c48View commit details
Commits on Jul 12, 2024
-
* Using exception helpers for .NET * Removing #regions * Fixing nullability in references to ZipPackagePartPiece.PieceDescriptors * Spacing/spelling/grammar changes to comments
Configuration menu - View commit details
-
Copy full SHA for 9519dc1 - Browse repository at this point
Copy the full SHA 9519dc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a82adfc - Browse repository at this point
Copy the full SHA a82adfcView commit details -
Swapped conditional compilation to newer form
Replaced references to NETFRAMEWORK and NETSTANDARD2_0 with NET and !NET as appropriate.
Configuration menu - View commit details
-
Copy full SHA for ad6b1f2 - Browse repository at this point
Copy the full SHA ad6b1f2View commit details