Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TensorPrimitives to vectorize for size(T) is 1 or 2 #97835

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Update TensorPrimitives to vectorize for size(T) is 1 or 2 #97835

merged 6 commits into from
Feb 8, 2024

Conversation

stephentoub
Copy link
Member

Fixes #96453

@stephentoub
Update TensorPrimitives to vectorize for size(T) is 1 or 2
4a7cae8 
It was previously only 4 or 8. This does the work previously skipped to enable the "less than largest available vector" path to handle these smaller sizes as well.
@stephentoub
Remove some unnecessary aggregations from small paths
4e4e1cf
@ghost ghost assigned stephentoub Feb 1, 2024
This was referenced Feb 1, 2024
Closed
Closed
Closed
This was referenced Feb 4, 2024
Open
Closed
tannergooding
tannergooding approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple comments that need fixing

@build-analysis build-analysis bot mentioned this pull request Feb 8, 2024
Closed
@stephentoub
Copy link
Member Author

All issues are known

@stephentoub stephentoub merged commit e3165d6 into dotnet:main Feb 8, 2024
103 of 111 checks passed
@stephentoub stephentoub deleted the addsmalltypesupport branch February 8, 2024 14:51
@build-analysis build-analysis bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Numerics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vectorize TensorPrimitive generic operations for sizeof(T) < 4
2 participants
@stephentoub @tannergooding