Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests for Apple platforms on hybrid mode #97550

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Exclude tests for Apple platforms on hybrid mode #97550

merged 2 commits into from
Jan 29, 2024

Conversation

mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Jan 26, 2024 •
edited
Loading

After #97299 , ICU specific tests started to fail on Apple platforms for HybridGlobalization.

@mkhamoyan mkhamoyan self-assigned this Jan 26, 2024
@ghost
Copy link

ghost commented Jan 26, 2024

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

After #97299 , ICU specific tests started to fail on Apple platforms.
Exclude these test cases for Apple platforms when HybridGlobalization.

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization
Milestone: -

@mkhamoyan mkhamoyan added the os-ios Apple iOS label Jan 26, 2024
@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@mkhamoyan mkhamoyan marked this pull request as ready for review January 26, 2024 13:23
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

ilonatommy
ilonatommy approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IgnoreSymbols is not a supported option on iOS, approving

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

This was referenced Jan 26, 2024
Open
Closed
Closed
Closed
@mkhamoyan
Copy link
Contributor Author

Failures are not related.

@mkhamoyan mkhamoyan merged commit 7101b8c into dotnet:main Jan 29, 2024
126 of 132 checks passed
@mkhamoyan mkhamoyan deleted the disable_non_hybrid_tests branch January 29, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkhamoyan @ilonatommy