Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JsonSerializer] Add support for out-of-order metadata reads. #97474

Merged
merged 5 commits into from
Feb 2, 2024
Merged

[JsonSerializer] Add support for out-of-order metadata reads. #97474

merged 5 commits into from
Feb 2, 2024

Conversation

eiriktsarpalis
Copy link
Member

Makes the following changes:

  1. Adds support for out-of-order metadata reads in JsonSerializer.
  2. Ensures that read JSON property names are always unescaped.

Fix #72604.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Jan 24, 2024
@ghost
Copy link

ghost commented Jan 24, 2024

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Makes the following changes:

  1. Adds support for out-of-order metadata reads in JsonSerializer.
  2. Ensures that read JSON property names are always unescaped.

Fix #72604.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jan 24, 2024
@eiriktsarpalis eiriktsarpalis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 24, 2024
@eiriktsarpalis
Copy link
Member Author

New API pending approval, please do not merge yet.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Jan 24, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Jan 25, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Jan 26, 2024
Open
3 tasks
@eiriktsarpalis eiriktsarpalis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 30, 2024
This was referenced Jan 31, 2024
Open
Open
Open
This was referenced Feb 1, 2024
Open
Closed
Closed
@eiriktsarpalis eiriktsarpalis merged commit 1a2f095 into dotnet:main Feb 2, 2024
105 of 111 checks passed
@eiriktsarpalis eiriktsarpalis deleted the feature/json-metadata-readahead branch February 2, 2024 14:18
@eiriktsarpalis eiriktsarpalis mentioned this pull request Feb 13, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo left review comments

@stephentoub stephentoub stephentoub approved these changes

@krwq krwq Awaiting requested review from krwq

@tarekgh tarekgh Awaiting requested review from tarekgh

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

JsonSerializer: Allow out-of-order reading of metadata properties.
4 participants
@eiriktsarpalis @EgorBo @stephentoub @jozkee